mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Duncan Sands <duncan.sands@math.u-psud.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: Simon Arlott <simon@arlott.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] cxacru: Store all device status information and report it when atm_proc_read is called.
Date: Thu, 1 Feb 2007 10:15:31 +0100	[thread overview]
Message-ID: <200702011015.32238.duncan.sands@math.u-psud.fr> (raw)
In-Reply-To: <20070131153914.eb693314.akpm@osdl.org>

On Thursday 1 February 2007 00:39:14 you wrote:
> On Tue, 30 Jan 2007 21:30:29 +0000
> Simon Arlott <simon@arlott.org> wrote:
> 
> > +static int cxacru_proc_read(struct usbatm_data *usbatm_instance,
> > +	struct atm_dev *atm_dev, loff_t * pos, char *page)
> > +{
> > +	struct cxacru_data *instance = usbatm_instance->driver_data;
> > +	u32 *cxinf = instance->cxinf_status;
> > +	int left = *pos;
> > +
> > +	if (!left--)
> > +		return sprintf(page, "# %s\n", usbatm_instance->description);
> > +
> > +	if (!left--) {
> > +		if (cxinf[CXINF_LINE_STATUS] == 5) {
> > +			return sprintf(page, "# UP %u/%u\n",
> > +				cxinf[CXINF_DOWNSTREAM_RATE],
> > +				cxinf[CXINF_UPSTREAM_RATE]);
> > +		} else {
> > +			return sprintf(page, "# DOWN\n");
> > +		}
> > +	}
> 
> hm, how well-tested was this proc interface?  The pread() and lseek()
> behaviour might be strange.
> 
> I guess as long as it doesn't oops, hang or anything like that then it'll
> be OK.  Anyone who does anything apart from a single big-fat-read from a 
> procfile has a good chance of getting into trouble :(

All the ATM drivers seem to do it like this.  That doesn't mean they are
right of course!  But I never saw anyone complain on the ATM mailing list.
On the other hand, why does Simon want this?  If he has written a user space
tool that extracts bits from the proc file (eg: to tell users what's going
on) then he could run into trouble, depending on how he implements it.

Ciao,

Duncan.

  reply	other threads:[~2007-02-01 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30 21:30 Simon Arlott
2007-01-31 14:19 ` Duncan Sands
2007-01-31 23:39 ` Andrew Morton
2007-02-01  9:15   ` Duncan Sands [this message]
2007-02-11 17:10     ` Simon Arlott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702011015.32238.duncan.sands@math.u-psud.fr \
    --to=duncan.sands@math.u-psud.fr \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@arlott.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®