From: Tilman Schmidt <tilman@imap.cc>
To: Andrew Morton <akpm@osdl.org>, Karsten Keil <kkeil@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
i4ldeveloper@listserv.isdn4linux.de
Cc: Hansjoerg Lipp <hjlipp@web.de>
Subject: [PATCH] drivers/isdn/gigaset: reduce kernel message spam
Date: Wed, 7 Feb 2007 22:40:38 +0100 [thread overview]
Message-ID: <200702072140.l17LecAh000466@lx1.pxnet.com> (raw)
Reduce the number of kernel messages the Gigaset drivers produce in
case of an excessively long device response, from one per character
exceeding the limit to one per overlong message.
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
isocdata.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.20-rc6-mm3-orig/drivers/isdn/gigaset/isocdata.c 2007-02-01 01:23:54.000000000 +0100
+++ linux-2.6.20-rc6-mm3-work/drivers/isdn/gigaset/isocdata.c 2007-02-05 17:35:47.000000000 +0100
@@ -921,6 +921,8 @@ static void cmd_loop(unsigned char *src,
/* end of line */
gig_dbg(DEBUG_TRANSCMD, "%s: End of Command (%d Bytes)",
__func__, cbytes);
+ if (cbytes >= MAX_RESP_SIZE - 1)
+ dev_warn(cs->dev, "response too large\n");
cs->cbytes = cbytes;
gigaset_handle_modem_response(cs);
cbytes = 0;
@@ -929,8 +931,6 @@ static void cmd_loop(unsigned char *src,
/* advance in line buffer, checking for overflow */
if (cbytes < MAX_RESP_SIZE - 1)
cbytes++;
- else
- dev_warn(cs->dev, "response too large\n");
}
}
reply other threads:[~2007-02-07 21:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702072140.l17LecAh000466@lx1.pxnet.com \
--to=tilman@imap.cc \
--cc=akpm@osdl.org \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®