From: Oleg Verych <olecom@flower.upol.cz>
To: David Miller <davem@davemloft.net>
Cc: paulus@samba.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: Kbuild change breaks the ppc64 build
Date: Thu, 8 Feb 2007 13:35:40 +0100 [thread overview]
Message-ID: <20070208123540.GT22699@flower.upol.cz> (raw)
In-Reply-To: <20070208.040003.112623191.davem@davemloft.net>
On Thu, Feb 08, 2007 at 04:00:03AM -0800, David Miller wrote:
> From: Paul Mackerras <paulus@samba.org>
> Date: Thu, 8 Feb 2007 22:10:54 +1100
[]
> Linus and Oleg tried to fix it with various subsequent changes
> to scripts/Kbuild.include, but it's still broken.
And Roland McGrath, but it turned to be very bad.
Maybe you have older set of fixes. I have x86-64 and i386 built,
though with make 3.81(debian).
But it may be ppc specific, as
CFLAGS += $(call cc-option,-mcpu=970)
else
CFLAGS += $(call cc-option,-mcpu=power4)
may be turned to be options without spaces (make V=1)!
> For some reason $(call ...) invocations add spaces. I tried
> another test case:
>
> define test
> $(shell echo -n)
> endef
>
> VAR:=$(call test)
>
> all:
> @echo "\'$(VAR)\'"
>
> And this always prints:
>
> ' TEST'
>
> even with GNU Make version 3.81
>
> If I put a $(strip ...) around the define, the space is
> still there. If I put the $(strip ...) around VAR's
> $(call), the space goes away.
____
next prev parent reply other threads:[~2007-02-08 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 11:10 Paul Mackerras
2007-02-08 12:00 ` David Miller
2007-02-08 12:35 ` Oleg Verych [this message]
2007-02-08 14:12 ` Michal Ostrowski
2007-02-08 12:47 ` Oleg Verych
2007-02-08 13:17 ` David Miller
2007-02-08 13:45 ` final (Re: Kbuild change breaks the ppc64 build) Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070208123540.GT22699@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®