From: Jeff Garzik <jeff@garzik.org>
To: Michael Clay <claym@osuosl.org>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: BusLogic check_region patch
Date: Mon, 12 Feb 2007 20:14:50 -0500 [thread overview]
Message-ID: <20070213011450.GA19511@havoc.gtf.org> (raw)
In-Reply-To: <20070213002704.GD9534@ash.osuosl.org>
On Mon, Feb 12, 2007 at 04:27:04PM -0800, Michael Clay wrote:
> This patch is meant to remove the calls to check_region, a now
> deprecated function in order to get rid of compilation warning. This
> was done by finding all calls to check_region and replacing them with
> calls to request_region. check_region essentially was a wrapper around
> request_region, and was checking if the request_region returned a
> pointer or null. As a result, I simply inlined the process of checking
> for null, eliminating the need to call the check_region wrapper.
Yes, but what happens when half the request_region() calls succeed, and
the other half fail?
You cannot simply substitute check_region with request_region.
Jeff
prev parent reply other threads:[~2007-02-13 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 0:27 Michael Clay
2007-02-13 1:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213011450.GA19511@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=claym@osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®