From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964877AbXBPQ4U (ORCPT ); Fri, 16 Feb 2007 11:56:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964882AbXBPQ4U (ORCPT ); Fri, 16 Feb 2007 11:56:20 -0500 Received: from lixom.net ([66.141.50.11]:50311 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964877AbXBPQ4T (ORCPT ); Fri, 16 Feb 2007 11:56:19 -0500 Date: Fri, 16 Feb 2007 11:05:32 -0600 To: trond.myklebust@fys.uio.no Cc: linux-kernel@vger.kernel.org Subject: [PATCH] nfs: init req_lock in nfs_alloc_inode Message-ID: <20070216170532.GA4895@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) From: olof@lixom.net (Olof Johansson) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: BUG: spinlock bad magic on CPU#0, mount/1073 lock: c00000007fdca108, .magic: 00000000, .owner: /24576, .owner_cpu: 0 Call Trace: [C00000007E913750] [C0000000000107B4] .show_stack+0x54/0x1f0 (unreliable) [C00000007E913800] [C0000000001D2234] .spin_bug+0xa4/0x120 [C00000007E913890] [C0000000001D247C] ._raw_spin_lock+0xdc/0x1d0 [C00000007E913930] [C0000000004DF990] ._spin_lock+0x10/0x30 [C00000007E9139B0] [C00000000017623C] .nfs_sync_mapping_wait+0xac/0x310 [C00000007E913AA0] [C000000000176F18] .nfs_sync_mapping_range+0x98/0x110 [C00000007E913B80] [C00000000016CAA0] .nfs_getattr+0x40/0xf0 [C00000007E913C20] [C0000000000BE668] .vfs_getattr+0x38/0x70 [C00000007E913CA0] [C0000000000BF05C] .vfs_fstat+0x3c/0x70 [C00000007E913D30] [C0000000000BF0B8] .sys_fstat64+0x28/0x60 [C00000007E913E30] [C000000000008608] syscall_exit+0x0/0x40 Signed-off-by: Olof Johansson --- Trond, is your MAINTAINERS entry up to date? Seems like you mostly post from @netapp.com these days. Index: linux-2.6/fs/nfs/inode.c =================================================================== --- linux-2.6.orig/fs/nfs/inode.c +++ linux-2.6/fs/nfs/inode.c @@ -1123,6 +1123,7 @@ struct inode *nfs_alloc_inode(struct sup nfsi->flags = 0UL; nfsi->cache_validity = 0UL; nfsi->cache_change_attribute = jiffies; + nfsi->req_lock = SPIN_LOCK_UNLOCKED; #ifdef CONFIG_NFS_V3_ACL nfsi->acl_access = ERR_PTR(-EAGAIN); nfsi->acl_default = ERR_PTR(-EAGAIN);