From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933073AbXBQWwf (ORCPT ); Sat, 17 Feb 2007 17:52:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933079AbXBQWwf (ORCPT ); Sat, 17 Feb 2007 17:52:35 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:58335 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933073AbXBQWwe (ORCPT ); Sat, 17 Feb 2007 17:52:34 -0500 Date: Sat, 17 Feb 2007 23:52:15 +0100 From: Pavel Machek To: Maxim Cc: netdev@kernel.org, linux-kernel@vger.kernel.org Subject: Re: Subject: [PATCH 2.6.20 004/005] dmfe: Add support for suspend/resume Message-ID: <20070217225215.GE14222@elf.ucw.cz> References: <200702152253.53680.maximlevitsky@gmail.com> <200702152311.54407.maximlevitsky@gmail.com> <20070217115029.GF9120@elf.ucw.cz> <200702180029.03651.maximlevitsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200702180029.03651.maximlevitsky@gmail.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Hello , I am sorry that I missed some parts of coding style. I need to reread it :-) > > There is a updated patch : It looks better. > + /* Disable Interrupt */ > + outl (0, dev->base_addr + DCR7); > + outl (inl(dev->base_addr + DCR5), dev->base_addr + DCR5); I'd kill space after outl... > + /* Free RX buffers */ > + dmfe_free_rxbuffer(db); > + > + /* Power down device*/ and add space before */. Congratulation, you passed coding-style-police-check ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html