From: Alan <alan@lxorguk.ukuu.org.uk>
To: Suleiman Souhlal <ssouhlal@FreeBSD.org>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Don't change transfer speed while requests are in flight
Date: Wed, 21 Feb 2007 13:12:59 +0000 [thread overview]
Message-ID: <20070221131259.3817762d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20070221012112.GB1777@freefall.freebsd.org>
> + * If we are in an interrupt, it should be safe to issue
> + * SETFEATURES manually, since there shouldn't be any requests in
> + * flight.
There may be error recovery going on from a timeout on another processor.
I don't see how your code protects against that (and the old code is
broken too)
prev parent reply other threads:[~2007-02-21 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 1:21 Suleiman Souhlal
2007-02-21 2:05 ` Bartlomiej Zolnierkiewicz
2007-02-21 13:12 ` Alan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221131259.3817762d@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssouhlal@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®