From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Jeff Dike <jdike@addtoit.com>,
akpm@osdl.org, stable@vger.kernel.org, uml@ligatura.org,
linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH] UML - Fix 2.6.20 hang
Date: Thu, 22 Feb 2007 01:22:06 +0100 [thread overview]
Message-ID: <200702220122.07414.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20070215170713.GB5641@ccure.user-mode-linux.org>
On Thursday 15 February 2007 18:07, Jeff Dike wrote:
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
[...]
> @@ -331,10 +334,9 @@ void maybe_sigio_broken(int fd, int read
>
> sigio_lock();
> err = need_poll(&all_sigio_fds, all_sigio_fds.used + 1);
> - if(err){
> - printk("maybe_sigio_broken - failed to add pollfd\n");
> + if(err)
> goto out;
> - }
> +
> all_sigio_fds.poll[all_sigio_fds.used++] =
> ((struct pollfd) { .fd = fd,
> .events = read ? POLLIN : POLLOUT,
>
Was that removal wanted or it happened by mistake? That way, err is completely
lost.
--
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
prev parent reply other threads:[~2007-02-22 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 17:07 Jeff Dike
2007-02-22 0:22 ` Blaisorblade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702220122.07414.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=uml@ligatura.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®