From: Pete Zaitcev <zaitcev@redhat.com>
To: Duncan Sands <duncan.sands@math.u-psud.fr>
Cc: Simon Arlott <254ad70138dc1cdf241hjzcr0007jhhw@thunder.lp0.eu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
zaitcev@redhat.com, linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] usbatm: Detect usb device shutdown and ignore failed urbs.
Date: Thu, 22 Feb 2007 15:53:18 -0800 [thread overview]
Message-ID: <20070222155318.19b423a9.zaitcev@redhat.com> (raw)
In-Reply-To: <200702221143.38809.duncan.sands@math.u-psud.fr>
On Thu, 22 Feb 2007 11:43:38 +0100, Duncan Sands <duncan.sands@math.u-psud.fr> wrote:
> > + /* the module/device has probably been removed */
> > + if (urb->status == -ESHUTDOWN)
> > + return;
> > +
> > if (printk_ratelimit())
> > atm_warn(channel->usbatm, "%s: urb 0x%p failed (%d)!\n",
> > __func__, urb, urb->status);
>
> I would rather just suppress the warning in this case, and still do the delayed
> schedule of the tasklet, in case this error was spurious and we're not really
> about to be disconnected.
I disagree. If ESHUTDOWN is received, the endpoint is definitely gone.
I can see why you might want to retry EPROTO, ELISEQ, etc. but this
case is different.
-- Pete
next prev parent reply other threads:[~2007-02-22 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 21:39 Simon Arlott
2007-02-22 10:43 ` Duncan Sands
2007-02-22 23:53 ` Pete Zaitcev [this message]
2007-02-23 9:36 ` Duncan Sands
2007-02-23 16:16 ` [linux-usb-devel] " Alan Stern
2007-02-23 17:05 ` Duncan Sands
2007-02-23 18:11 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222155318.19b423a9.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=254ad70138dc1cdf241hjzcr0007jhhw@thunder.lp0.eu \
--cc=duncan.sands@math.u-psud.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome