From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
To: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
akpm@osdl.org, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
gregkh@novell.com
Subject: Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)
Date: Thu, 22 Feb 2007 16:38:50 -0600 [thread overview]
Message-ID: <20070222223850.GD14162@beardog.cca.cpqcorp.net> (raw)
In-Reply-To: <20070222215501.GA21037@infradead.org>
On Thu, Feb 22, 2007 at 09:55:01PM +0000, Christoph Hellwig wrote:
> On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote:
> > On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote:
> > > .remove = __devexit_p(cciss_remove_one),
> > > .id_table = cciss_pci_device_id, /* id_table */
> > > + .shutdown = cciss_remove_one,
> >
> > You need a __devexit_p() wrapper for this one too.
>
> No. We want to call this even in the non-modular, non-hotplug
> case. So we should remove __devexit from cciss_remove_one. Or
> alternatively implement a separate cciss_shutdown that just does
> the nessecary cache flushing, like most other drivers do.
So if I remove __devexit from cciss_init_one do I also remove the __devexit_p wrapper
from the remove method?
-- mikem
next prev parent reply other threads:[~2007-02-22 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 21:38 Mike Miller (OS Dev)
2007-02-22 21:45 ` Christoph Hellwig
2007-02-22 21:56 ` Mike Miller (OS Dev)
2007-02-22 23:08 ` Greg KH
2007-02-22 21:49 ` James Bottomley
2007-02-22 21:55 ` Christoph Hellwig
2007-02-22 22:38 ` Mike Miller (OS Dev) [this message]
2007-02-22 21:50 ` scott.ashcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222223850.GD14162@beardog.cca.cpqcorp.net \
--to=mikem@beardog.cca.cpqcorp.net \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=gregkh@novell.com \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®