From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: typo in include/linux/irqflags.h ?
Date: Sat, 24 Feb 2007 13:14:22 +0000 [thread overview]
Message-ID: <20070224131422.GA5047@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.60.0702241243270.1583@rtl14.hofr.at>
On Sat, Feb 24, 2007 at 12:45:16PM +0100, Nicholas Mc Guire wrote:
>
> Hi !
>
> Seems like there was a cut&past error in include/linux/riqflags.h.
>
>
> --- linux-2.6.20/include/linux/irqflags.h 2007-02-04 09:44:54.000000000 -0900
> +++ linux-2.6.20xm/include/linux/irqflags.h 2008-01-27 20:29:26.000000000 -0900
> @@ -91,6 +91,6 @@
> })
>
> #define irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags)
> -#endif /* CONFIG_X86 */
> +#endif /* CONFIG_TRACE_IRQFLAGS_SUPPORT */
Just yet rid of the comment - you can see the corresponding #ifdef on
the screen without paging up or down so it seems pointless to have such
a comment - it just adds additional unnecessary clutter to the screen.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-02-24 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 11:45 Nicholas Mc Guire
2007-02-24 13:14 ` Russell King [this message]
2007-02-24 12:56 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070224131422.GA5047@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=der.herr@hofr.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®