From: Pete Zaitcev <zaitcev@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-kernel-list <linux-kernel@vger.kernel.org>,
<tony.olech@elandigitalsystems.com>,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH] USB Elan FTDI: check for workqueue creation v2
Date: Sat, 24 Feb 2007 16:44:48 -0800 [thread overview]
Message-ID: <20070224164448.8fe872c7.zaitcev@redhat.com> (raw)
In-Reply-To: <20070224074115.GB10139@cvg>
On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> Thanks a lot for comments and Ack the patch please.
Cyrill, I forgot to mention a couple of points, sorry.
> printk(KERN_INFO "driver %s built at %s on %s\n", ftdi_elan_driver.name,
> - __TIME__, __DATE__);
> + __TIME__, __DATE__);
Is this really necessary?
> respond_queue = create_singlethread_workqueue("ftdi-respond-engine");
> + if (!respond_queue)
> + goto err3;
This is good, but...
> result = usb_register(&ftdi_elan_driver);
> if (result)
> printk(KERN_ERR "usb_register failed. Error number %d\n",
> - result);
> + result);
> return result;
What does happen if usb_register fails? Since you fixed the
create_singlethread_workqueue, why not this too?
-- Pete
cc: to Tony@ELAN and linux-usb-devel
prev parent reply other threads:[~2007-02-25 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 7:41 Cyrill Gorcunov
2007-02-24 12:46 ` Oleg Verych
2007-02-24 14:38 ` Cyrill Gorcunov
2007-02-25 0:44 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070224164448.8fe872c7.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=tony.olech@elandigitalsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®