From: David Miller <davem@davemloft.net>
To: j.j.green@sheffield.ac.uk
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: sparc64 / bbc_i2c.c
Date: Mon, 26 Feb 2007 10:12:19 -0800 (PST) [thread overview]
Message-ID: <20070226.101219.18306730.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0702252352310.32309@parallax.ddns.shef.ac.uk>
From: "J.J.Green" <j.j.green@sheffield.ac.uk>
Date: Sun, 25 Feb 2007 23:58:48 +0000 (GMT)
> Hi Andrew
>
> > The code around there looks relatively unbuggy to me. Removing that
> > remove_wait_queue() would be very bad - it would cause later stack
> > corruption.
> >
> > msleep_interruptible() certainly shouldn't consume CPU like that. Do we
> > know where the CPU time is being spent? The output of:
> >
> > readprofile -r
> > sleep 10
> > readprofile -n -v -m /boot/System.map | sort -n -k 3 | tail -40
> >
> > would tell us.
>
> As was mentioned in another reply, this message by
> Joerg Friedrich
>
> http://lists.debian.org/debian-sparc/2007/02/msg00045.html
>
> gives a possible explanantion of where the time is going.
> I applied the patch to the debian kernel sources for 2.6.18,
> it applied cleanly and fixed the problem.
I've added Joerg's patch to my tree and will push it into
-stable as well.
Reviewing this patch had been sitting deep in my backlog for weeks, I
just never got around to it, sorry.
next prev parent reply other threads:[~2007-02-26 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 13:27 J.J. Green
2007-02-25 12:47 ` Andrew Morton
2007-02-25 13:33 ` Emanuele Rocca
2007-02-25 23:58 ` J.J.Green
2007-02-26 18:12 ` David Miller [this message]
2007-02-27 5:22 ` Joerg Friedrich
2007-02-27 5:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070226.101219.18306730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=j.j.green@sheffield.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®