From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pavel Machek <pavel@ucw.cz>, Oleg Nesterov <oleg@tv-sign.ru>,
vatsa@in.ibm.com, Gautham R Shenoy <ego@in.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
LKML <linux-kernel@vger.kernel.org>, David Chinner <dgc@sgi.com>,
Nigel Cunningham <ncunningham@linuxmail.org>
Subject: [PATCH] Make XFS workqueues nonfreezable
Date: Thu, 1 Mar 2007 00:54:32 +0100 [thread overview]
Message-ID: <200703010054.33536.rjw@sisk.pl> (raw)
In-Reply-To: <20070228224443.GC19542@elf.ucw.cz>
Since freezable workqueues are broken in 2.6.21-rc
(cf. http://marc.theaimsgroup.com/?l=linux-kernel&m=116855740612755,
http://marc.theaimsgroup.com/?l=linux-kernel&m=117261312523921&w=2)
it's better to change the only user of them, which is XFS, to use "normal"
nonfreezable workqueues.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
fs/xfs/linux-2.6/xfs_buf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.21-rc2/fs/xfs/linux-2.6/xfs_buf.c
===================================================================
--- linux-2.6.21-rc2.orig/fs/xfs/linux-2.6/xfs_buf.c
+++ linux-2.6.21-rc2/fs/xfs/linux-2.6/xfs_buf.c
@@ -1829,11 +1829,11 @@ xfs_buf_init(void)
if (!xfs_buf_zone)
goto out_free_trace_buf;
- xfslogd_workqueue = create_freezeable_workqueue("xfslogd");
+ xfslogd_workqueue = create_workqueue("xfslogd");
if (!xfslogd_workqueue)
goto out_free_buf_zone;
- xfsdatad_workqueue = create_freezeable_workqueue("xfsdatad");
+ xfsdatad_workqueue = create_workqueue("xfsdatad");
if (!xfsdatad_workqueue)
goto out_destroy_xfslogd_workqueue;
next prev parent reply other threads:[~2007-02-28 23:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 21:51 Problem with freezable workqueues Rafael J. Wysocki
2007-02-27 23:28 ` Oleg Nesterov
2007-02-27 23:36 ` Johannes Berg
2007-02-28 0:00 ` Rafael J. Wysocki
2007-02-28 0:00 ` Johannes Berg
2007-02-28 18:06 ` Gautham R Shenoy
2007-02-27 23:57 ` Rafael J. Wysocki
2007-02-28 0:01 ` Johannes Berg
2007-02-28 0:08 ` Rafael J. Wysocki
2007-02-28 1:14 ` Nigel Cunningham
2007-02-28 10:59 ` Rafael J. Wysocki
2007-02-28 20:36 ` Johannes Berg
2007-02-28 3:07 ` Srivatsa Vaddagiri
2007-02-28 8:48 ` Oleg Nesterov
2007-02-28 9:10 ` Srivatsa Vaddagiri
2007-02-28 9:43 ` Oleg Nesterov
2007-02-28 11:09 ` Rafael J. Wysocki
2007-02-28 18:17 ` Gautham R Shenoy
2007-02-28 18:41 ` Rafael J. Wysocki
2007-02-28 8:54 ` Pavel Machek
2007-02-28 3:01 ` Srivatsa Vaddagiri
2007-02-28 3:51 ` Srivatsa Vaddagiri
2007-02-28 11:11 ` Rafael J. Wysocki
2007-02-28 13:17 ` Srivatsa Vaddagiri
2007-02-28 13:27 ` Srivatsa Vaddagiri
2007-02-28 17:41 ` Rafael J. Wysocki
2007-02-28 17:40 ` Rafael J. Wysocki
2007-02-28 19:17 ` Rafael J. Wysocki
2007-02-28 19:32 ` Oleg Nesterov
2007-02-28 19:43 ` Rafael J. Wysocki
2007-02-28 20:08 ` Oleg Nesterov
2007-02-28 20:25 ` Rafael J. Wysocki
2007-02-28 20:35 ` Oleg Nesterov
2007-02-28 22:39 ` Rafael J. Wysocki
2007-02-28 22:44 ` Pavel Machek
2007-02-28 23:54 ` Rafael J. Wysocki [this message]
2007-03-01 8:03 ` [PATCH] Make XFS workqueues nonfreezable Andrew Morton
2007-03-01 9:15 ` Pavel Machek
2007-03-01 9:25 ` Andrew Morton
2007-02-28 21:16 ` Problem with freezable workqueues Pavel Machek
2007-03-06 0:30 ` Johannes Berg
2007-03-06 20:31 ` Rafael J. Wysocki
2007-03-06 22:25 ` Nigel Cunningham
2007-03-06 22:57 ` Rafael J. Wysocki
2007-03-07 23:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703010054.33536.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=dgc@sgi.com \
--cc=ego@in.ibm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=oleg@tv-sign.ru \
--cc=pavel@ucw.cz \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®