From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mathieu Desnoyers <compudj@google.com>, linux-kernel@vger.kernel.org
Subject: Re: Thread flags modified without set_thread_flag() (non atomically)
Date: Thu, 1 Mar 2007 10:34:51 +0100 [thread overview]
Message-ID: <20070301103451.2618cc35@dhcp-252-105.norway.atmel.com> (raw)
In-Reply-To: <20070228220349.b42bf571.akpm@linux-foundation.org>
[trimming cc list since I'm only replying to the avr32 part]
On Wed, 28 Feb 2007 22:03:49 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 26 Feb 2007 12:10:37 -0800 Mathieu Desnoyers <compudj@google.com> wrote:
> > avr32/kernel/ptrace.c: ti->flags |= _TIF_BREAKPOINT;
>
> No, I don't immediately see anything in the flush_old_exec() code path
> which tells us that nobody else can look up this thread_info (or be holding
> a ref to it) in this context.
>
>
> > avr32/kernel/ptrace.c: ti->flags |= TIF_SINGLE_STEP;
>
> heh. Haarvard, you got a bug.
Heh, yeah. That would indeed explain some strange gdb behaviour. It
will only trigger when single-stepping into an exception or interrupt
handler so thanks for pointing it out; I would have had a hard time
figuring it out on my own...
I don't think either of those need to be atomic though, since both of
them happen in monitor mode with interrupts disabled.
Haavard
next prev parent reply other threads:[~2007-03-01 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 20:10 Mathieu Desnoyers
2007-03-01 6:03 ` Andrew Morton
2007-03-01 6:23 ` David Miller
2007-03-01 8:17 ` Andrew Morton
2007-03-01 9:34 ` Haavard Skinnemoen [this message]
2007-03-01 9:45 ` Andrew Morton
2007-03-01 10:14 ` Haavard Skinnemoen
2007-03-01 15:13 ` Haavard Skinnemoen
2007-03-01 19:59 ` Mathieu Desnoyers
2007-03-01 22:41 ` Andrew Morton
2007-03-05 16:30 ` Kyle Moffett
2007-03-05 14:40 ` Andi Kleen
2007-03-05 22:04 ` Andrew Morton
2007-03-06 4:35 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301103451.2618cc35@dhcp-252-105.norway.atmel.com \
--to=hskinnemoen@atmel.com \
--cc=akpm@linux-foundation.org \
--cc=compudj@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®