Hello, here my last patch for the PXA27x keyboard support updated to linux-2.6.21-rc2. I added power management support (suspend/resume code). Machines should call the driver with the following code: static struct pxa27x_keyboard_platform_data wwpc1100_kbd = { .nr_rows = 4, .nr_cols = 4, .keycodes = { { /* row 0 */ KEY_ESC, KEY_ENTER, KEY_F1, -1, }, { /* row 1 */ KEY_F2, KEY_F3, KEY_F4, -1, }, { /* row 2 */ KEY_UP, KEY_LEFT, KEY_RIGHT, -1, }, { /* row 3 */ KEY_DOWN, -1, -1, -1, }, }, .gpio_modes = { GPIO100_KP_MKIN0, GPIO101_KP_MKIN1, GPIO102_KP_MKIN2, GPIO97_KP_MKIN3, GPIO103_KP_MKOUT0, GPIO104_KP_MKOUT1, GPIO105_KP_MKOUT2, GPIO106_KP_MKOUT3, }, }; static struct platform_device wwpc1100_keyboard = { .name = "pxa27x-keyboard", .id = -1, .dev = { .platform_data = &wwpc1100_kbd, }, }; static struct platform_device *platform_devices[] __initdata = { &wwpc1100_audio_device, &wwpc1100_keyboard, &wwpc1100_lcd_bl_device, &wwpc1100_keyb_bl_device, }; Signed-off-by: Rodolfo Giometti ---