From: Andi Kleen <andi@firstfloor.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Jan-Bernd Themann <ossthema@de.ibm.com>,
Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH] ehea: Optional TX/RX path optimized for SMP
Date: Sat, 3 Mar 2007 13:33:40 +0100 [thread overview]
Message-ID: <20070303123340.GB5357@one.firstfloor.org> (raw)
In-Reply-To: <1172910508.8184.53.camel@localhost.localdomain>
On Sat, Mar 03, 2007 at 09:28:28AM +0100, Benjamin Herrenschmidt wrote:
> On Sat, 2007-03-03 at 04:06 +0100, Andi Kleen wrote:
> > Jan-Bernd Themann <ossthema@de.ibm.com> writes:
> > >
> > > Are there any concerns about this approach?
> >
> > Yes. You should fix the NAPI code instead of trying to work
> > around it.
>
> NAPI is being fixed but the fix will take time to get in. In the
> meantime, the solution to get something working is the workaround
If it works right now with just a little less efficiency there
is no pressing need to do workarounds until the real solution.
Besides I doubt that patch would have made .21 anyways and in .22
you might already have multiqueue NAPI.
-Andi
prev parent reply other threads:[~2007-03-03 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-23 16:30 Jan-Bernd Themann
2007-02-23 16:49 ` Roland Dreier
2007-02-26 13:43 ` Jan-Bernd Themann
2007-03-03 3:06 ` Andi Kleen
2007-03-03 8:28 ` Benjamin Herrenschmidt
2007-03-03 12:33 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070303123340.GB5357@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®