From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbXCDRDD (ORCPT ); Sun, 4 Mar 2007 12:03:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751882AbXCDRDD (ORCPT ); Sun, 4 Mar 2007 12:03:03 -0500 Received: from rgminet01.oracle.com ([148.87.113.118]:44942 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbXCDRDB (ORCPT ); Sun, 4 Mar 2007 12:03:01 -0500 Date: Sun, 4 Mar 2007 08:59:24 -0800 From: Randy Dunlap To: "Robert P. J. Day" Cc: Linux Kernel Mailing List , Roman Zippel , trivial@kernel.org Subject: Re: [PATCH] KCONFIG: Add some extra info regarding the kernel localversion. Message-Id: <20070304085924.b1a209f5.randy.dunlap@oracle.com> In-Reply-To: References: Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 4 Mar 2007 06:01:17 -0500 (EST) Robert P. J. Day wrote: > > A small formatting fix, and add a few lines describing the origin of > the git-based "localversion" string for the kernel version. > > Signed-off-by: Robert P. J. Day > > --- > > diff --git a/init/Kconfig b/init/Kconfig > index f977086..4d5aef6 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -80,13 +80,19 @@ config LOCALVERSION_AUTO > default y > help > This will try to automatically determine if the current tree is a > - release tree by looking for git tags that > - belong to the current top of tree revision. > + release tree by looking for git tags that belong to the current > + top of tree revision. > > A string of the format -gxxxxxxxx will be added to the localversion > - if a git based tree is found. The string generated by this will be > + if a git-based tree is found. The string generated by this will be > appended after any matching localversion* files, and after the value > - set in CONFIG_LOCALVERSION > + set in CONFIG_LOCALVERSION. (The actual string is the first eight > + characters produced by running the command: > + > + $ git rev-parse --verify HEAD > + > + which is done within the script "scripts/setlocalversion", in case > + you were interested.) Please omit ", in case you were interested". > > Note: This requires Perl, and a git repository, but not necessarily > the git or cogito tools to be installed. How can this be the case since a 'git' command is used, according to your new documentation? --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***