From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Nick Piggin <npiggin@suse.de>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
akpm@linux-foundation.org, mingo@elte.hu,
linux-kernel@vger.kernel.org
Subject: Re: [patch] sched: optimize siblings status check logic in wake_idle()
Date: Sun, 4 Mar 2007 20:24:53 -0800 [thread overview]
Message-ID: <20070304202453.D27368@unix-os.sc.intel.com> (raw)
In-Reply-To: <20070305045831.GA2972@wotan.suse.de>; from npiggin@suse.de on Mon, Mar 05, 2007 at 05:58:31AM +0100
On Mon, Mar 05, 2007 at 05:58:31AM +0100, Nick Piggin wrote:
> On Sun, Mar 04, 2007 at 08:13:09PM -0800, Suresh B wrote:
> > On a 16 node system, we have seen ~1.25% perf improvement on a database workload
> > when we completely short circuited wake_idle(). This patch is trying to comeup
> > with a best compromise to avoid the cache misses and also minimize the latenices,
> > perf impact.
>
> Hmm, I wonder what if we only wake_idle if the wakeup comes from this
> CPU or a sibling? That's probably going to have downsides in some
> workloads as well, though.
yep. I thought about it and thought this patch is a decent solution.
thanks,
suresh
prev parent reply other threads:[~2007-03-05 5:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 4:23 Siddha, Suresh B
2007-03-05 2:35 ` Nick Piggin
2007-03-05 4:13 ` Siddha, Suresh B
2007-03-05 4:58 ` Nick Piggin
2007-03-05 4:24 ` Siddha, Suresh B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070304202453.D27368@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®