From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbXCDVa7 (ORCPT ); Sun, 4 Mar 2007 16:30:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752095AbXCDVa7 (ORCPT ); Sun, 4 Mar 2007 16:30:59 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:44893 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbXCDVa6 (ORCPT ); Sun, 4 Mar 2007 16:30:58 -0500 Date: Sun, 4 Mar 2007 22:31:28 +0100 From: Sam Ravnborg To: "Robert P. J. Day" Cc: Randy Dunlap , Linux Kernel Mailing List , Roman Zippel , trivial@kernel.org Subject: Re: [PATCH] KCONFIG: Add some extra info regarding the kernel localversion. Message-ID: <20070304213128.GA26553@uranus.ravnborg.org> References: <20070304085924.b1a209f5.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 04, 2007 at 12:10:18PM -0500, Robert P. J. Day wrote: > On Sun, 4 Mar 2007, Randy Dunlap wrote: > > > On Sun, 4 Mar 2007 06:01:17 -0500 (EST) Robert P. J. Day wrote: > > > > > > > > A small formatting fix, and add a few lines describing the origin of > > > the git-based "localversion" string for the kernel version. > > > > > > Signed-off-by: Robert P. J. Day > > > > > > --- > > > > > > diff --git a/init/Kconfig b/init/Kconfig > > > index f977086..4d5aef6 100644 > > > --- a/init/Kconfig > > > +++ b/init/Kconfig > > > @@ -80,13 +80,19 @@ config LOCALVERSION_AUTO > > > default y > > > help > > > This will try to automatically determine if the current tree is a > > > - release tree by looking for git tags that > > > - belong to the current top of tree revision. > > > + release tree by looking for git tags that belong to the current > > > + top of tree revision. > > > > > > A string of the format -gxxxxxxxx will be added to the localversion > > > - if a git based tree is found. The string generated by this will be > > > + if a git-based tree is found. The string generated by this will be > > > appended after any matching localversion* files, and after the value > > > - set in CONFIG_LOCALVERSION > > > + set in CONFIG_LOCALVERSION. (The actual string is the first eight > > > + characters produced by running the command: > > > + > > > + $ git rev-parse --verify HEAD > > > + > > > + which is done within the script "scripts/setlocalversion", in case > > > + you were interested.) > > > > Please omit ", in case you were interested". > > ok, will resubmit. > > > > > > > Note: This requires Perl, and a git repository, but not necessarily > > > the git or cogito tools to be installed. > > > > How can this be the case since a 'git' command is used, according to > > your new documentation? > > i have no idea why that last part says that -- that's not part of my > addition, it's the original text. in fact, there's nothing about > scripts/setlocalversion that seems to require perl, so that last part > is *doubly* odd. In the past setlocalversion was a perl script. Sam