Re: [PATCH] ocfs2: fix module_init error handling

[Joel Becker <Joel.Becker@oracle.com>]

On Sun, Mar 04, 2007 at 10:34:43PM +0900, Akinobu Mita wrote:
> From: Akinobu Mita <akinobu.mita@gmail.com>
> Subject: [PATCH] ocfs2: fix module_init error handling
> 
> Fix error handling in module_init and make module_init() return
> correct error code.

	What are you fixing specifically?  This looks like you are
reorganizing the exit path.  While stylistic differences can exist on
the choice of function exit, claiming there is a "fix" means there is an
actual bug.  Please clarify the bug so we can evaluate your change.

> -leave:
> -	if (status < 0) {
> -		ocfs2_free_mem_caches();
> -		exit_ocfs2_uptodate_cache();
> -		exit_ocfs2_extent_maps();
> -	}
> +	status = register_filesystem(&ocfs2_fs_type);
> +	if (status)
> +		goto err_filesystem;
>  
>  	mlog_exit(status);

	Also, this change suppresses some paths to mlog_exit(), which
impacts people tracing.
	If there is an actual bug you are fixing, please tell us.  We'll
work with you to correct it.

Joel

-- 

Life's Little Instruction Book #451

	"Don't be afraid to say, 'I'm sorry.'"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127