mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Surya <surya.prabhakar@wipro.com>
Cc: mulix@mulix.org, linux-kernel@vger.kernel.org,
	kernel-janitors <kernel-janitors@lists.osdl.org>
Subject: Re: [kj]patch7:replace pci_find_device in sound/oss/trident.c
Date: Tue, 6 Mar 2007 16:41:49 +0000	[thread overview]
Message-ID: <20070306164149.36e3b855@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1173175287.32705.5.camel@bluegenie>

On Tue, 06 Mar 2007 15:31:27 +0530
Surya <surya.prabhakar@wipro.com> wrote:

> Hi,
>  Cleanup of pci_find_device to pci_get_device in sound/oss/trident.c
> Applies and compiles clean to latest Linus tree. Not tested!


Thanks. 

I would move the pci_dev_put inside the if as well (the variable is only
used in the ALi section so could itself also be moved), but the fix
appears correct.

Alan

      reply	other threads:[~2007-03-06 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06 10:01 Surya
2007-03-06 16:41 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070306164149.36e3b855@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mulix@mulix.org \
    --cc=surya.prabhakar@wipro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®