From: David Miller <davem@davemloft.net>
To: eparis@parisplace.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jmorris@namei.org, vyekkirala@trustedcs.com,
cxzhang@watson.ibm.com, sds@tycho.nsa.gov
Subject: Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget
Date: Wed, 07 Mar 2007 16:07:40 -0800 (PST) [thread overview]
Message-ID: <20070307.160740.77057241.davem@davemloft.net> (raw)
In-Reply-To: <20070307.154316.68038380.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 07 Mar 2007 15:43:16 -0800 (PST)
> From: Eric Paris <eparis@parisplace.org>
> Date: Fri, 02 Mar 2007 13:51:24 -0500
>
> > pfkey_spdget neither had an LSM security hook nor auditing for the
> > removal of xfrm_policy structs. The security hook was added when it was
> > moved into xfrm_policy_byid instead of the callers to that function by
> > my earlier patch and this patch adds the auditing hooks as well.
> >
> > Signed-off-by: Eric Paris <eparis@redhat.com>
>
> Applied.
This patch was missing an openning brace on the "if (delete)" line.
Eric you don't post patches without at least compile testing
them now do you? :-)
I fixed this up, but I will just kick it back to you next time,
and I will likely growl very loudly in your general direction
too. ;)
next prev parent reply other threads:[~2007-03-08 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 18:51 Eric Paris
2007-03-05 15:59 ` Venkat Yekkirala
2007-03-06 0:37 ` James Morris
2007-03-07 23:43 ` David Miller
2007-03-08 0:07 ` David Miller [this message]
2007-03-08 16:20 ` Eric Paris
2007-03-08 17:12 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307.160740.77057241.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cxzhang@watson.ibm.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=vyekkirala@trustedcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome