From: Christoph Hellwig <hch@infradead.org>
To: Deepak Saxena <dsaxena@plexity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix building kernel under Solaris
Date: Wed, 7 Mar 2007 09:42:29 +0000 [thread overview]
Message-ID: <20070307094229.GG14863@infradead.org> (raw)
In-Reply-To: <20070306180940.GA3240@plexity.net>
On Tue, Mar 06, 2007 at 10:09:40AM -0800, Deepak Saxena wrote:
> @@ -16,8 +16,10 @@
> #include <sys/time.h>
> #include <sys/ioctl.h>
> #include <sys/types.h>
> +#ifndef __sun__
> #include <asm/types.h>
> #endif
> +#endif
So if solaris doesn't need it, why do we need it on Linux?
> +/*
> + * Solaris does not strsep
> + */
> +#ifndef __sun__
> while ((fname = strsep(&sources, " ")) != NULL) {
> if (!*fname)
> continue;
> +#else
> + for (fname = strtok(sources, " "); fname; fname = strtok(NULL, " ")) {
> +#endif
> if (!parse_source_files(fname, &md))
> goto release;
> }
Please either provide a strsep for solaris, or use strtok unconditionally.
ut this ifdef mess is not acceptable.
>
next prev parent reply other threads:[~2007-03-07 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 18:09 Deepak Saxena
2007-03-06 18:22 ` Deepak Saxena
2007-03-06 19:23 ` Sam Ravnborg
2007-03-07 9:42 ` Christoph Hellwig [this message]
2007-03-07 22:45 ` Jan Engelhardt
2007-03-08 8:35 ` Christoph Hellwig
2007-03-08 20:43 ` Jan Engelhardt
2007-03-08 21:25 ` Sam Ravnborg
2007-03-08 22:01 ` [PATCH] Fix building kernel under Solaris 11_snv Jan Engelhardt
2007-03-09 19:00 ` Sam Ravnborg
2007-03-09 20:16 ` Jan Engelhardt
2007-03-09 22:23 ` Sam Ravnborg
2007-03-09 22:55 ` Jan Engelhardt
2007-03-10 9:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307094229.GG14863@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome