From: Christoph Hellwig <hch@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Roman Zippel <zippel@linux-m68k.org>,
David Brown <dmlb2000@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
gdb@sourceware.org
Subject: Re: PAGE_SIZE Availability Inconsistency
Date: Thu, 8 Mar 2007 16:08:52 +0000 [thread overview]
Message-ID: <20070308160852.GB9916@infradead.org> (raw)
In-Reply-To: <1173369229.3550.2.camel@laptopd505.fenrus.org>
On Thu, Mar 08, 2007 at 07:53:49AM -0800, Arjan van de Ven wrote:
> > > > PAGE_SIZE should not be available at all. Please use getpagesize()
> > > > instead.
> > >
> > > While I agree, NBPG is a bit of a problem, although it's only needed for aout
> > > coredumps AFAICT, but still needed to compile e.g. gdb.
> >
> > So we should export this one with an arbitrary value (on multiple page
> > size architectures) and a warning, maybe even an __deprecated attached to
> > it.
>
> if we think the kernel should export this one, we could do
>
> #ifndef __KERNEL__
> #define PAGE_SIZE getpagesize()
> #endif
No, no no. We should never export PAGE_SIZE. We might export NBPG
as deprecated symbol for gdb if it really needs it, but that should
happen only on a.out systems, and it it should be a true constant,
not depending on PAGE_SIZE.
I've Cc'ed the gdb list on whether they have any comments on this
issue.
next prev parent reply other threads:[~2007-03-08 16:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 23:55 David Brown
2007-03-05 23:59 ` Eric Dumazet
2007-03-06 0:01 ` Randy Dunlap
2007-03-06 0:03 ` David Miller
2007-03-06 0:04 ` David Brown
2007-03-06 0:26 ` David Miller
2007-03-06 2:21 ` H. Peter Anvin
2007-03-08 21:08 ` Avi Kivity
2007-03-08 22:21 ` H. Peter Anvin
2007-03-19 19:39 ` Eric W. Biederman
2007-03-06 9:29 ` Christoph Hellwig
2007-03-08 2:18 ` Roman Zippel
2007-03-08 5:28 ` David Brown
2007-03-08 8:32 ` Christoph Hellwig
2007-03-08 9:00 ` Christoph Hellwig
2007-03-08 15:53 ` Arjan van de Ven
2007-03-08 16:08 ` Christoph Hellwig [this message]
2007-03-08 16:21 ` Daniel Jacobowitz
2007-03-08 17:05 ` H. Peter Anvin
2007-03-08 17:12 ` Christoph Hellwig
2007-03-08 17:57 ` Anton Blanchard
2007-03-08 18:04 ` H. Peter Anvin
2007-03-08 21:42 ` Anton Blanchard
2007-03-08 21:46 ` Anton Blanchard
2007-03-08 21:48 ` David Miller
2007-03-09 2:43 ` Anton Blanchard
2007-03-09 4:18 ` H. Peter Anvin
2007-03-09 4:27 ` David Miller
2007-03-09 4:31 ` H. Peter Anvin
2007-03-09 4:36 ` David Miller
2007-03-21 2:12 ` Anton Blanchard
2007-03-21 2:48 ` H. Peter Anvin
2007-03-08 22:22 ` H. Peter Anvin
2007-03-08 21:03 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308160852.GB9916@infradead.org \
--to=hch@infradead.org \
--cc=arjan@infradead.org \
--cc=dmlb2000@gmail.com \
--cc=gdb@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®