From: David Miller <davem@davemloft.net>
To: mathieu.desnoyers@polymtl.ca
Cc: linux-kernel@vger.kernel.org
Subject: sparc atomicity patches reverted
Date: Fri, 09 Mar 2007 23:15:41 -0800 (PST) [thread overview]
Message-ID: <20070309.231541.112624204.davem@davemloft.net> (raw)
The sparc64 one doesn't even compile, please fix this up and resubmit,
thank you. I'd like you to redo the 32-bit sparc patch too.
Please, I recommend that you use {sec,clear,etc.}_ti_thread_flag() in
this and the 32-bit sparc TI_USEDFPU patch, instead of the task
versions which could add an unnecessary pointer dereference to go from
tsk to the thread_info.
It is likely that had you used the thread based flag helpers from the
start, you would not have created this build failure.
Thanks again.
--------------------
arch/sparc64/kernel/process.c: In function ^[$,1rx^[(Bflush_thread^[$,1ry^[(B:
arch/sparc64/kernel/process.c:416: error: ^[$,1rx^[(Btsk^[$,1ry^[(B undeclared (first use in this function)
arch/sparc64/kernel/process.c:416: error: (Each undeclared identifier is reported only once
arch/sparc64/kernel/process.c:416: error: for each function it appears in.)
--------------------
diff --git a/arch/sparc64/kernel/process.c b/arch/sparc64/kernel/process.c
index 7d75cd4..646ace4 100644
--- a/arch/sparc64/kernel/process.c
+++ b/arch/sparc64/kernel/process.c
@@ -413,8 +413,13 @@ void flush_thread(void)
struct thread_info *t = current_thread_info();
struct mm_struct *mm;
- if (t->flags & _TIF_ABI_PENDING)
- t->flags ^= (_TIF_ABI_PENDING | _TIF_32BIT);
+ if (test_tsk_thread_flag(tsk, TIF_ABI_PENDING)) {
+ clear_tsk_thread_flag(tsk, TIF_ABI_PENDING);
+ if (test_tsk_thread_flag(tsk, TIF_32BIT))
+ clear_tsk_thread_flag(tsk, TIF_32BIT);
+ else
+ set_tsk_thread_flag(tsk, TIF_32BIT);
+ }
mm = t->task->mm;
if (mm)
--
1.5.0
reply other threads:[~2007-03-10 7:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309.231541.112624204.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®