From: Nick Piggin <npiggin@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [rfc][patch] futex: restartable futex_wait?
Date: Fri, 9 Mar 2007 06:10:38 +0100 [thread overview]
Message-ID: <20070309051038.GA12479@wotan.suse.de> (raw)
In-Reply-To: <20070308172902.GA16834@elte.hu>
On Thu, Mar 08, 2007 at 06:29:02PM +0100, Ingo Molnar wrote:
>
> * Nick Piggin <npiggin@suse.de> wrote:
>
> > Hi Ingo,
> >
> > I'm seeing an LTP test fail for ltp test sigaction_16_24. Basically,
> > it tests whether the SA_RESTART flag works for the sem_wait operation.
> >
> > I see sem_wait is implemented with futex_wait, so I wonder whether we
> > can make it restartable? Am I going about it the right way? (Seems to
> > fix the testcase here).
>
> i think that's quite right. I'm wondering why this never came up before?
> But your fix is not complete i think:
>
> > + restart->arg2 = time;
> > + return -ERESTART_RESTARTBLOCK;
> > + }
>
> 'time' here is relative, so the restarted syscall will do a /full/ wait
> again.
But it has been modified by schedule_timeout?
next prev parent reply other threads:[~2007-03-09 5:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 15:33 Nick Piggin
2007-03-08 17:29 ` Ingo Molnar
2007-03-08 23:02 ` Thomas Gleixner
2007-03-09 5:15 ` Nick Piggin
2007-03-09 5:10 ` Nick Piggin [this message]
2007-03-09 9:38 ` Thomas Gleixner
2007-03-09 12:24 ` Nick Piggin
2007-03-09 13:10 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309051038.GA12479@wotan.suse.de \
--to=npiggin@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®