From: Andrey Panin <pazke@donpac.ru>
To: Amit Choudhary <amit2030@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/media/video/videocodec.c: check kmalloc() return value.
Date: Fri, 9 Mar 2007 12:04:11 +0300 [thread overview]
Message-ID: <20070309090411.GC18056@pazke.donpac.ru> (raw)
In-Reply-To: <20070308231401.42679647.amit2030@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On 067, 03 08, 2007 at 11:14:01PM -0800, Amit Choudhary wrote:
> Description: Check the return value of kmalloc() in function videocodec_build_table(), in file drivers/media/video/videocodec.c.
>
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>
> diff --git a/drivers/media/video/videocodec.c b/drivers/media/video/videocodec.c
> index 2ae3fb2..16fc1dd 100644
> --- a/drivers/media/video/videocodec.c
> +++ b/drivers/media/video/videocodec.c
> @@ -348,6 +348,8 @@ #define LINESIZE 100
> kfree(videocodec_buf);
> videocodec_buf = (char *) kmalloc(size, GFP_KERNEL);
>
> + if (!videocodec_buf)
> + return 0;
> i = 0;
> i += scnprintf(videocodec_buf + i, size - 1,
> "<S>lave or attached <M>aster name type flags magic ");
Can you also remove useless (char *) cast above ?
--
Andrey Panin | Linux and UNIX system administrator
pazke@donpac.ru | PGP key: wwwkeys.pgp.net
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-03-09 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 7:14 Amit Choudhary
2007-03-09 9:04 ` Andrey Panin [this message]
2007-03-12 10:45 ` Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309090411.GC18056@pazke.donpac.ru \
--to=pazke@donpac.ru \
--cc=amit2030@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®