From: Oliver Neukum <oneukum@suse.de>
To: Amit Choudhary <amit2030@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.
Date: Fri, 9 Mar 2007 09:14:24 +0100 [thread overview]
Message-ID: <200703090914.24242.oneukum@suse.de> (raw)
In-Reply-To: <20070308231833.69b0611e.amit2030@gmail.com>
Am Freitag, 9. März 2007 08:18 schrieb Amit Choudhary:
> Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.
No, this is wrong. You must catch this at the source. The driver
cannot function if this function always returns -ENOMEM. It makes
no sense to start up the device under these circumstances.
Regards
Oliver
prev parent reply other threads:[~2007-03-09 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 7:18 Amit Choudhary
2007-03-09 8:14 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703090914.24242.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=amit2030@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®