From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767236AbXCINPQ (ORCPT ); Fri, 9 Mar 2007 08:15:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767278AbXCINPQ (ORCPT ); Fri, 9 Mar 2007 08:15:16 -0500 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:49305 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1767236AbXCINPO (ORCPT ); Fri, 9 Mar 2007 08:15:14 -0500 Date: Fri, 9 Mar 2007 14:12:46 +0000 From: Alan Cox To: "Pekka Enberg" Cc: "Eric Dumazet" , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, hch@infradead.org, serue@us.ibm.com Subject: Re: [PATCH 2/7] revoke: add f_light flag for struct file Message-ID: <20070309141246.2059c9dc@lxorguk.ukuu.org.uk> In-Reply-To: <84144f020703090358o76d1d82bk9479792173445fe3@mail.gmail.com> References: <200703091108.58371.dada1@cosmosbay.com> <84144f020703090243j6fd49b5eoa23f4cc12866725a@mail.gmail.com> <200703091213.35691.dada1@cosmosbay.com> <84144f020703090352s3ecd8ab4pdde6f24f6cf7cc47@mail.gmail.com> <84144f020703090358o76d1d82bk9479792173445fe3@mail.gmail.com> X-Mailer: Claws Mail 2.7.2 (GTK+ 2.10.8; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > Btw, what we can do is delay closing the actual revoked file until the > task terminates. This has the unfortunate side-effect that a task has > no way of freeing the resources now. But, I am beginning to think it's > not a big problem because the inode mapping will be zapped immediately > upon revoke anyway... Actually you can't entirely do this. The revoke() definition states explicitly that the driver close occurs at the point of revoke() not later. That can however be pushed into the device revoke method for the cases where it might matter (eg tty). Alan