From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767517AbXCITgq (ORCPT ); Fri, 9 Mar 2007 14:36:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767519AbXCITgq (ORCPT ); Fri, 9 Mar 2007 14:36:46 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:33463 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767517AbXCITgo (ORCPT ); Fri, 9 Mar 2007 14:36:44 -0500 From: "Rafael J. Wysocki" To: Heiko Carstens Subject: Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend Date: Fri, 9 Mar 2007 20:39:19 +0100 User-Agent: KMail/1.9.5 Cc: Pavel Machek , Andrew Morton , LKML References: <200703072044.12021.rjw@sisk.pl> <20070307210716.GA4913@ucw.cz> <20070309122934.GA8412@osiris.boeblingen.de.ibm.com> In-Reply-To: <20070309122934.GA8412@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703092039.20131.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Friday, 9 March 2007 13:29, Heiko Carstens wrote: > On Wed, Mar 07, 2007 at 09:07:17PM +0000, Pavel Machek wrote: > > Hi! > > > > > Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > > from triggering by disabling nonboot CPUs before we finally enter the platform > > > suspend. > > > > > > Signed-off-by: Rafael J. Wysocki > > > --- > > > kernel/power/disk.c | 1 + > > > kernel/power/user.c | 2 +- > > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > > > Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > =================================================================== > > > --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c > > > +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > @@ -61,6 +61,7 @@ static void power_down(suspend_disk_meth > > > switch(mode) { > > > case PM_DISK_PLATFORM: > > > if (pm_ops && pm_ops->enter) { > > > + disable_nonboot_cpus(); > > > kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK); > > > pm_ops->enter(PM_SUSPEND_DISK); > > > break; > > > > ...so, if pm_ops is non-null, power_down does nonboot cpu disabling, > > otherwise we proceed with cpus enabled? > > > > That looks ugly. > > > > Is the warning bogus? Or maybe we should *always* disable nonboot cpus > > in powerdown path? > > Is disable_nonboot_cpus() assuming that first_cpu(cpu_present_map) is > the boot cpu? Just wondering why disable_nonboot_cpus() isn't using just > any_online_cpu(cpu_online_map)... Is your question related to the code in kernel/cpu.c? Rafael