From: David Miller <davem@davemloft.net>
To: wli@holomorphy.com
Cc: mathieu.desnoyers@polymtl.ca, akpm@linux-foundation.org,
mbligh@google.com, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] Fix sparc TIF_USEDFPU flag atomicity
Date: Sat, 10 Mar 2007 00:29:44 -0800 (PST) [thread overview]
Message-ID: <20070310.002944.115909724.davem@davemloft.net> (raw)
In-Reply-To: <20070310082646.GC2994@holomorphy.com>
From: William Lee Irwin III <wli@holomorphy.com>
Date: Sat, 10 Mar 2007 00:26:46 -0800
> On Sat, Mar 10, 2007 at 03:17:43AM -0500, Mathieu Desnoyers wrote:
> > @@ -348,7 +348,7 @@ void exit_thread(void)
> > #ifndef CONFIG_SMP
> > if(last_task_used_math == current) {
> > #else
> > - if(current_thread_info()->flags & _TIF_USEDFPU) {
> > + if(test_ti_thread_flag(current_thread_info(), TIF_USEDFPU)) {
> > #endif
> > /* Keep process from leaving FPU in a bogon state. */
> > put_psr(get_psr() | PSR_EF);
>
> Oh dear. Could we bit a bit more idiomatic here? For instance,
> something like:
Ok I pulled the sparc32 patch back out until there is some
consensus here :)
next prev parent reply other threads:[~2007-03-10 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 8:17 Mathieu Desnoyers
2007-03-10 8:26 ` William Lee Irwin III
2007-03-10 8:29 ` David Miller [this message]
2007-03-10 10:59 ` William Lee Irwin III
2007-03-10 16:31 ` Mathieu Desnoyers
2007-03-10 8:28 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-03-09 3:12 Mathieu Desnoyers
2007-03-09 5:25 ` David Miller
2007-03-09 11:20 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070310.002944.115909724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®