From: Ingo Molnar <mingo@elte.hu>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ulrich Drepper <drepper@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] futex: restartable futex_wait
Date: Sat, 10 Mar 2007 10:09:00 +0100 [thread overview]
Message-ID: <20070310090900.GA18250@elte.hu> (raw)
In-Reply-To: <20070310033753.GA13299@wotan.suse.de>
* Nick Piggin <npiggin@suse.de> wrote:
> LTP test sigaction_16_24 fails, because it expects sem_wait to be
> restarted if SA_RESTART is set. sem_wait is implemented with
> futex_wait, that currently doesn't support being restarted. Ulrich
> confirms that the call should be restartable.
>
> Implement a restart_block method to handle the relative timeout, and
> allow restarts.
>
> Signed-off-by: Nick Piggin <npiggin@suse.de>
yeah:
Acked-by: Ingo Molnar <mingo@elte.hu>
i was totally confused and thought this was the original argument:
> + restart->arg2 = time;
> + return -ERESTART_RESTARTBLOCK;
but it's indeed the 'new' relative timeout. (It can still be a tiny bit
inaccurate because if there are many signals then the signals will delay
the relative timeout - so absolute timeouts are still better - but your
fix is correct and needed nevertheless)
Ingo
prev parent reply other threads:[~2007-03-10 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 3:37 Nick Piggin
2007-03-10 9:09 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070310090900.GA18250@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=drepper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®