From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH] KVM: MMU: Fix host memory corruption on i386 with >= 4GB ram
Date: Sun, 11 Mar 2007 11:33:34 +0100 [thread overview]
Message-ID: <20070311103334.GB23396@elte.hu> (raw)
In-Reply-To: <11736076282800-git-send-email-avi@qumranet.com>
* Avi Kivity <avi@qumranet.com> wrote:
> PAGE_MASK is an unsigned long, so using it to mask physical addresses
> on i386 (which are 64-bit wide) leads to truncation. This can result
> in page->private of unrelated memory pages being modified, with
> disasterous results.
>
> Fix by not using PAGE_MASK for physical addresses; instead calculate
> the correct value directly from PAGE_SIZE. Also fix a similar
> BUG_ON().
>
> Signed-off-by: Avi Kivity <avi@qumranet.com>
i have tested this, albeit with less than 4GB RAM.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
prev parent reply other threads:[~2007-03-11 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 10:07 [PATCH 0/2] KVM: More fixes for 2.6.21-rc3 Avi Kivity
2007-03-11 10:07 ` [PATCH] KVM: MMU: Fix guest writes to nonpae pde Avi Kivity
2007-03-11 10:32 ` [kvm-devel] " Ingo Molnar
2007-03-11 10:07 ` [PATCH] KVM: MMU: Fix host memory corruption on i386 with >= 4GB ram Avi Kivity
2007-03-11 10:33 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070311103334.GB23396@elte.hu \
--to=mingo@elte.hu \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®