From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Fabio Comolli <fabio.comolli@gmail.com>,
Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT
Date: Mon, 12 Mar 2007 12:10:32 +0000 [thread overview]
Message-ID: <20070312121032.3cfd1786@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <45F50E28.7010509@gmail.com>
> 1. I think these ports should be made dummy instead of returning
> -ENOENT on prereset(). -ENOENT from prereset() was a hack to keep
> ata_piix's behavior unchanged while converting it to new EH. If no
> one objcts, I'll convert similar usages to use dummy ports after new
> init model and drop -ENOENT hack in #upstream.
No objection at all.
> 2. -ENODEV sounds more appropriate. Why have I used -ENOENT. :-)
You didn't - I did. I think -ENOENT is better as we are missing an entire
channel not a device (disk).
>
next prev parent reply other threads:[~2007-03-12 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 16:31 [git patches] libata (and devres) fixes Jeff Garzik
2007-03-09 21:24 ` Fabio Comolli
2007-03-09 21:43 ` Jeff Garzik
2007-03-09 23:48 ` Alan Cox
2007-03-10 15:28 ` Fabio Comolli
2007-03-12 8:24 ` [PATCH] libata: don't whine if ->prereset() returns -ENOENT Tejun Heo
2007-03-12 12:10 ` Alan Cox [this message]
2007-03-12 20:14 ` Fabio Comolli
2007-03-19 16:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312121032.3cfd1786@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=fabio.comolli@gmail.com \
--cc=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®