From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030307AbXCLOyt (ORCPT ); Mon, 12 Mar 2007 10:54:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030309AbXCLOyr (ORCPT ); Mon, 12 Mar 2007 10:54:47 -0400 Received: from nat-132.atmel.no ([80.232.32.132]:52356 "EHLO relay.atmel.no" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030307AbXCLOyq (ORCPT ); Mon, 12 Mar 2007 10:54:46 -0400 Date: Mon, 12 Mar 2007 15:53:59 +0100 From: Haavard Skinnemoen To: Haavard Skinnemoen Cc: bryan.wu@analog.com, David Brownell , Jean Delvare , Andrew Morton , Deepak Saxena , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Bitbanging i2c bus driver using the GPIO API Message-ID: <20070312155359.39020c80@dhcp-252-105.norway.atmel.com> In-Reply-To: <20070312153457.60dafa0c@dhcp-252-105.norway.atmel.com> References: <200703091345.44744.david-b@pacbell.net> <11735324081261-git-send-email-hskinnemoen@atmel.com> <1173694079.6638.13.camel@roc-desktop> <20070312153457.60dafa0c@dhcp-252-105.norway.atmel.com> Organization: Atmel Norway X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Mar 2007 15:34:57 +0100 Haavard Skinnemoen wrote: > > > + bit_data->udelay = 5, /* 100 kHz */ > > > + bit_data->timeout = HZ / 10, /* 100 ms */ > > > > Can we add these udelay/timeout to struct i2c_gpio_platform_data? And > > let customer to choose these according their specific requirement. We > > use Kconfig to do this, but Jean and David don't like the idea, -:( > > Yeah, they need to be a bit more configurable than they currently are. > And I think it makes sense to pass them from the board setup code, since > this is where things depending on board-specific details (signal quality > issues, pullup resistor values, etc.) are supposed to go. By the way, timeout seems to be hardcoded to 100 jiffies in the i2c-algo-bit driver, so there's probably not much point passing it from the board code when it's going to be overridden anyway. I'll add just a udelay parameter to the platform struct for now. Haavard