From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933215AbXCMUcs (ORCPT ); Tue, 13 Mar 2007 16:32:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933298AbXCMUcs (ORCPT ); Tue, 13 Mar 2007 16:32:48 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:43228 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933215AbXCMUcr (ORCPT ); Tue, 13 Mar 2007 16:32:47 -0400 Date: Tue, 13 Mar 2007 20:32:44 +0000 From: Christoph Hellwig To: Kandan Venkataraman Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] Loop device - Tracking page writes made to a loop device through mmap Message-ID: <20070313203244.GA13914@infradead.org> Mail-Followup-To: Christoph Hellwig , Kandan Venkataraman , linux-kernel@vger.kernel.org, akpm@linux-foundation.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 14, 2007 at 07:21:41AM +1100, Kandan Venkataraman wrote: > All comments have been taken care of. > > Description: > > A file_operations structure variable called loop_fops is initialised with > the default block device file operations (def_blk_fops). > The mmap operation is overriden with a new function called loop_file_mmap. NACK. block device driver should never ever play around with file operations themselves. If you want functionality like the one you have please don't overload the loop driver, but start a new (character) driver doing specificaly what you want. And even then I'm not sure we'd want functionality like this in the mainline tree, but at least we can have an open discussion if it's done properly.