From: Greg KH <greg@kroah.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove "decl_subsys_name" macro and single usage of it.
Date: Thu, 15 Mar 2007 00:25:03 -0700 [thread overview]
Message-ID: <20070315072503.GB8016@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703011205510.20928@CPE00045a9c397f-CM001225dbafb6>
On Thu, Mar 01, 2007 at 12:09:59PM -0500, Robert P. J. Day wrote:
>
> Remove the macro "decl_subsys_name" which can be used to declare a
> sysfs subsystem, along with the single invocation of it in the source
> tree, since there appears to be little value in creating a subsystem
> whose subsystem name differs from its structure name. Everyone else
> just uses "decl_subsys".
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> @@ -800,7 +800,7 @@ MODULE_LICENSE("GPL");
> module_param(debug, bool, 0644);
> MODULE_PARM_DESC(debug, "Debugging mode enabled or not");
>
> -EXPORT_SYMBOL_GPL(pci_hotplug_slots_subsys);
> +EXPORT_SYMBOL_GPL(slots_subsys);
No, don't polute the namespace incorrectly here. We really want the
variable to still have the "pci_hotplug_" prefix if at all possible.
thanks,
greg k-h
next prev parent reply other threads:[~2007-03-15 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 17:09 Robert P. J. Day
2007-03-15 7:25 ` Greg KH [this message]
2007-03-15 10:22 ` Kay Sievers
2007-03-15 12:52 ` Robert P. J. Day
2007-03-15 13:08 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070315072503.GB8016@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®