From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965544AbXCOMjD (ORCPT ); Thu, 15 Mar 2007 08:39:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965547AbXCOMjC (ORCPT ); Thu, 15 Mar 2007 08:39:02 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56444 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965544AbXCOMjB (ORCPT ); Thu, 15 Mar 2007 08:39:01 -0400 Date: Thu, 15 Mar 2007 13:38:59 +0100 From: Nick Piggin To: Peter Zijlstra Cc: Ashif Harji , linux-mm@kvack.org, Jan Kara , linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed Message-ID: <20070315123859.GC8321@wotan.suse.de> References: <20070312142012.GH30777@atrey.karlin.mff.cuni.cz> <20070312143900.GB6016@wotan.suse.de> <20070312151355.GB23532@duck.suse.cz> <20070312173500.GF23532@duck.suse.cz> <20070313185554.GA5105@duck.suse.cz> <1173955154.25356.28.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1173955154.25356.28.camel@twins> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2007 at 11:39:14AM +0100, Peter Zijlstra wrote: > On Wed, 2007-03-14 at 15:58 -0400, Ashif Harji wrote: > > This patch unconditionally calls mark_page_accessed to prevent pages, > > especially for small files, from being evicted from the page cache despite > > frequent access. > > Since we're hackling over the use-once stuff again... > > /me brings up: http://marc.info/?l=linux-mm&m=115316894804385&w=2 and > ducks. Join the club ;) http://groups.google.com.au/group/linux.kernel/msg/7b3237b8e715475b?hl=en& I can't find the patch where I actually did combine it with a PG_usedonce bit, but the end result is pretty similar to your patch. And I think one or two others have also independently invented the same thing. So it *has* to be good, doesn't it? ;)