mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: Chris Wedgwood <cw@f00f.org>,
	linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>
Subject: Re: [ibm-acpi-devel] [PATCH] ACPI: ibm-acpi: allow module to load when acpi notifiers can't be set
Date: Thu, 15 Mar 2007 16:57:32 -0300	[thread overview]
Message-ID: <20070315195732.GG14394@khazad-dum.debian.net> (raw)
In-Reply-To: <20070315123732.2ac478a3.kristen.c.accardi@intel.com>

On Thu, 15 Mar 2007, Kristen Carlson Accardi wrote:
> I haven't followed the ibm_acpi development lately, but when I first
> wrote the bay driver, it had a couple features that ibm_acpi didn't have,
> and then of course, is missing some it does have.  What used to be the
> case is that if bay was inserted after the laptop was booted, the ibm_acpi
> driver would not capture the events because it would only install it's 
> notifier at driver load time on bay devices that existed.  The second

This is still true, I didn't bother fixing it because I'd rather expend "bay
time" trying to get the generic driver to work OK in thinkpads, but I have
been otherwise distracted with other ibm-acpi things, like a sysfs
conversion.

> as the X60, you need to have undock events sent to the bay device so that
> it can alert user space to unmount cd's etc (since the bay is on the ultrabase).

This is also still true.

BTW, currently the bay driver seems to have lost a lot of functionality, I
remember older incarnations of it (before it went platform-driver) caused
unplugs to be clean instead of driving libata nuts...  Am I recalling this
incorrectly?

> I think for now this is a good idea - the ibm_acpi solution should be
> preferred over the generic bay driver till it is more fully developed.
> I don't know how to ensure this is done wrt load order though.

Nor do I, and sincerely, if one is doing what some rpm distros are and
loading every ACPI module in a for loop at boot time, I don't want to know.
It is their mess to fix.  I just have ibm-acpi in my /etc/modules, and
arranged it to be loaded BEFORE any such distro crap (not that Debian has
it, but still...).

What we *can* do is to have DMI-based coldplug capabilities added, and work
from there to get udev to autoload devices.  And that still won't be 100%
failure-proof, but nothing is.

> I think this is a good idea.  It would certainly be less confusing for users.
> too late for this release though, perhaps this can be targetted at 2.6.22/23?

That's something I'd like to happen.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2007-03-15 19:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-15  7:10 [PATCH] ACPI_IBM_BAY can not coexist with ACPI_BAY Chris Wedgwood
2007-03-15 13:27 ` Henrique de Moraes Holschuh
2007-03-15 15:04 ` Henrique de Moraes Holschuh
2007-03-15 17:51 ` [PATCH] ACPI: ibm-acpi: allow module to load when acpi notifiers can't be set Henrique de Moraes Holschuh
2007-03-15 19:15   ` [PATCH] ACPI: ibm-acpi: allow module to load when acpi notifiers can't be set (v2) Henrique de Moraes Holschuh
2007-03-16  5:24     ` Len Brown
2007-03-15 19:17   ` [PATCH] ACPI: ibm-acpi: allow module to load when acpi notifiers can't be set Chris Wedgwood
2007-03-15 19:37     ` Kristen Carlson Accardi
2007-03-15 19:57       ` Henrique de Moraes Holschuh [this message]
2007-03-15 21:57       ` Holger Macht
2007-03-15 19:39     ` Henrique de Moraes Holschuh
2007-03-15 19:26   ` Kristen Carlson Accardi
2007-03-15 19:48     ` [ibm-acpi-devel] " Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070315195732.GG14394@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=cw@f00f.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=kristen.c.accardi@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®