From: Sam Ravnborg <sam@ravnborg.org>
To: Bodo Eggert <7eggert@gmx.de>
Cc: Kumar Gala <galak@kernel.crashing.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: Kconfig style question
Date: Fri, 16 Mar 2007 21:09:27 +0100 [thread overview]
Message-ID: <20070316200927.GB22200@uranus.ravnborg.org> (raw)
In-Reply-To: <E1HS7G6-0001Cr-19@be1.lrz>
On Fri, Mar 16, 2007 at 08:53:53AM +0100, Bodo Eggert wrote:
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
> > For source lines I've seen both:
> >
> > source "arch/powerpc/platforms/52xx/Kconfig"
> >
> > and
> >
> > source arch/powerpc/platforms/85xx/Kconfig
> >
> > Is there a preferred style? Quotes or not?
>
> $ find . -name Kconfig -exec grep ^source '{}' \;|grep \"|wc -l
> 732
> $ find . -name Kconfig -exec grep ^source '{}' \;|grep -v \"|wc -l
> 44
Which is somewaht funny.
source is defined like this:
"source" <prompt>
Where <prompt> may be a single string without spaces or
a quoted string with spaces.
So kconfig allow you to use spaces in the path/filename. But
then most users uses "" despite it is not needed since we obviously
do not use spaces in path/filename in the kernel due to
make limitations (and good taste).
Sam
next prev parent reply other threads:[~2007-03-16 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7Z7fc-4ZL-21@gated-at.bofh.it>
2007-03-16 7:53 ` Bodo Eggert
2007-03-16 20:09 ` Sam Ravnborg [this message]
2007-03-15 23:01 Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316200927.GB22200@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=7eggert@gmx.de \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®