From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1751530AbXCSOdn@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751530AbXCSOdn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Mar 2007 10:33:43 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751529AbXCSOdn
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 19 Mar 2007 10:33:43 -0400
Received: from mail.screens.ru ([213.234.233.54]:53913 "EHLO mail.screens.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751200AbXCSOdm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Mar 2007 10:33:42 -0400
Date: Mon, 19 Mar 2007 17:37:23 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH, take3] getrusage() : Fill ru_inblock and ru_oublock fields if possible
Message-ID: <20070319143723.GA152@tv-sign.ru>
References: <20070319130213.bb387150.dada1@cosmosbay.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070319130213.bb387150.dada1@cosmosbay.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/19, Eric Dumazet wrote:
>
> [...snip...]
>  			do {
>  				utime = cputime_add(utime, t->utime);
> @@ -2040,6 +2045,8 @@ static void k_getrusage(struct task_stru
>  				r->ru_nivcsw += t->nivcsw;
>  				r->ru_minflt += t->min_flt;
>  				r->ru_majflt += t->maj_flt;
> +				r->ru_inblock += task_io_get_inblock(t);
> +				r->ru_oublock += task_io_get_oublock(t);
>  				t = next_thread(t);
>  			} while (t != p);

(offtopic)

We are reading u64 read_bytes/write_bytes which could be updated asynchronously.
/proc/pid/io does the same.

Of course, I don't blame this patch, just a stupid question: can we do something?
I guess not.

Oleg.