From: Mikael Pettersson <mikpe@it.uu.se>
To: ak@suse.de, mikpe@it.uu.se
Cc: akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
bzolnier@gmail.com, jesper.juhl@gmail.com,
linux-kernel@vger.kernel.org, trent.waddington@gmail.com
Subject: Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning
Date: Tue, 20 Mar 2007 12:56:02 +0100 (MET) [thread overview]
Message-ID: <200703201156.l2KBu2o5024611@harpo.it.uu.se> (raw)
On Tue, 20 Mar 2007 12:29:49 +0100 (CET), Andreas Kleen <ak@suse.de> wrote:
> > The floppy driver's sysfs file just provides some auxiliary
> > information to user-space, none of which matters for most of
> > its users. It is IMO totally inappropriate to fail floppy
> > driver init in this case.
>
> I thought it was for udev to create the device nodes? But
> I might be wrong on that.
It's a file called "cmos" containing the ASCII
representation of UDP->cmos, which appears to be some
kind of "type" indicator. See floppy_cmos_show().
The file is only readable, not even root can write to it.
On one of my machines it contains the value "4", but the
device nodes udev created are still just /dev/fd0 and
/dev/floppy -> /dev/fd0, so I don't think it affects udev.
The "cmos" file seems to be a relatively new addition,
as another machine here running an RHEL4 2.6.9 kernel
doesn't have it.
Unless someone can prove that it's useful I think it
should be removed.
/Mikael
next reply other threads:[~2007-03-20 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 11:56 Mikael Pettersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-03-20 8:32 Mikael Pettersson
2007-03-20 9:24 ` Jesper Juhl
2007-03-21 7:11 ` Dmitriy Monakhov
2007-03-20 11:29 ` Andreas Kleen
2007-03-19 15:11 Jesper Juhl
2007-03-19 15:13 ` Andi Kleen
2007-03-19 15:16 ` Jesper Juhl
2007-03-19 15:20 ` Andi Kleen
2007-03-19 17:42 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703201156.l2KBu2o5024611@harpo.it.uu.se \
--to=mikpe@it.uu.se \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trent.waddington@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®