From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: 2.6.21-rc4-mm1: multiple definition of `queue_pushbutton_work'
Date: Wed, 21 Mar 2007 11:45:31 -0700 [thread overview]
Message-ID: <20070321114531.feffad51.kristen.c.accardi@intel.com> (raw)
In-Reply-To: <20070320204936.GE752@stusta.de>
Fix duplicate names in shpchp and pciehp.
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Index: 2.6-mm/drivers/pci/hotplug/pciehp.h
===================================================================
--- 2.6-mm.orig/drivers/pci/hotplug/pciehp.h
+++ 2.6-mm/drivers/pci/hotplug/pciehp.h
@@ -158,7 +158,7 @@ extern u8 pciehp_handle_presence_change(
extern u8 pciehp_handle_power_fault(u8 hp_slot, struct controller *ctrl);
extern int pciehp_configure_device(struct slot *p_slot);
extern int pciehp_unconfigure_device(struct slot *p_slot);
-extern void queue_pushbutton_work(struct work_struct *work);
+extern void pciehp_queue_pushbutton_work(struct work_struct *work);
int pcie_init(struct controller *ctrl, struct pcie_device *dev);
static inline struct slot *pciehp_find_slot(struct controller *ctrl, u8 device)
Index: 2.6-mm/drivers/pci/hotplug/pciehp_core.c
===================================================================
--- 2.6-mm.orig/drivers/pci/hotplug/pciehp_core.c
+++ 2.6-mm/drivers/pci/hotplug/pciehp_core.c
@@ -229,7 +229,7 @@ static int init_slots(struct controller
slot->hpc_ops = ctrl->hpc_ops;
slot->number = ctrl->first_slot;
mutex_init(&slot->lock);
- INIT_DELAYED_WORK(&slot->work, queue_pushbutton_work);
+ INIT_DELAYED_WORK(&slot->work, pciehp_queue_pushbutton_work);
/* register this slot with the hotplug pci core */
hotplug_slot->private = slot;
Index: 2.6-mm/drivers/pci/hotplug/pciehp_ctrl.c
===================================================================
--- 2.6-mm.orig/drivers/pci/hotplug/pciehp_ctrl.c
+++ 2.6-mm/drivers/pci/hotplug/pciehp_ctrl.c
@@ -351,7 +351,7 @@ static void pciehp_power_thread(struct w
kfree(info);
}
-void queue_pushbutton_work(struct work_struct *work)
+void pciehp_queue_pushbutton_work(struct work_struct *work)
{
struct slot *p_slot = container_of(work, struct slot, work.work);
struct power_work_info *info;
Index: 2.6-mm/drivers/pci/hotplug/shpchp.h
===================================================================
--- 2.6-mm.orig/drivers/pci/hotplug/shpchp.h
+++ 2.6-mm/drivers/pci/hotplug/shpchp.h
@@ -166,7 +166,7 @@ extern u8 shpchp_handle_power_fault(u8 h
extern int shpchp_configure_device(struct slot *p_slot);
extern int shpchp_unconfigure_device(struct slot *p_slot);
extern void cleanup_slots(struct controller *ctrl);
-extern void queue_pushbutton_work(struct work_struct *work);
+extern void shpchp_queue_pushbutton_work(struct work_struct *work);
extern int shpc_init( struct controller *ctrl, struct pci_dev *pdev);
#ifdef CONFIG_ACPI
Index: 2.6-mm/drivers/pci/hotplug/shpchp_core.c
===================================================================
--- 2.6-mm.orig/drivers/pci/hotplug/shpchp_core.c
+++ 2.6-mm/drivers/pci/hotplug/shpchp_core.c
@@ -136,7 +136,7 @@ static int init_slots(struct controller
slot->hpc_ops = ctrl->hpc_ops;
slot->number = ctrl->first_slot + (ctrl->slot_num_inc * i);
mutex_init(&slot->lock);
- INIT_DELAYED_WORK(&slot->work, queue_pushbutton_work);
+ INIT_DELAYED_WORK(&slot->work, shpchp_queue_pushbutton_work);
/* register this slot with the hotplug pci core */
hotplug_slot->private = slot;
Index: 2.6-mm/drivers/pci/hotplug/shpchp_ctrl.c
===================================================================
--- 2.6-mm.orig/drivers/pci/hotplug/shpchp_ctrl.c
+++ 2.6-mm/drivers/pci/hotplug/shpchp_ctrl.c
@@ -433,7 +433,7 @@ static void shpchp_pushbutton_thread(str
kfree(info);
}
-void queue_pushbutton_work(struct work_struct *work)
+void shpchp_queue_pushbutton_work(struct work_struct *work)
{
struct slot *p_slot = container_of(work, struct slot, work.work);
struct pushbutton_work_info *info;
next prev parent reply other threads:[~2007-03-21 18:48 UTC|newest]
Thread overview: 145+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 4:56 2.6.21-rc4-mm1 Andrew Morton
2007-03-20 7:54 ` 2.6.21-rc4-mm1 Michal Piotrowski
2007-03-20 9:45 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-22 8:41 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-22 9:48 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-22 10:04 ` 2.6.21-rc4-mm1 Con Kolivas
2007-03-22 17:07 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-22 18:17 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-22 22:14 ` 2.6.21-rc4-mm1 Con Kolivas
2007-03-23 6:18 ` 2.6.21-rc4-mm1 Con Kolivas
2007-03-23 8:45 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-23 12:28 ` 2.6.21-rc4-mm1 Andy Whitcroft
2007-03-23 15:53 ` 2.6.21-rc4-mm1 Fortier,Vincent [Montreal]
2007-03-23 21:45 ` 2.6.21-rc4-mm1 Con Kolivas
2007-03-23 23:26 ` debug rsdl 0.33 Con Kolivas
2007-03-25 12:27 ` Andy Whitcroft
2007-03-25 18:28 ` Torsten Kaiser
2007-03-25 22:01 ` Andrew Morton
2007-03-25 22:49 ` Con Kolivas
2007-03-25 22:59 ` Con Kolivas
2007-03-26 7:49 ` Andy Whitcroft
2007-03-26 15:28 ` Andy Whitcroft
2007-03-26 16:12 ` Con Kolivas
2007-03-20 10:52 ` 2.6.21-rc4-mm1 [PATCH] init/missing_syscalls.h fix Stephane Jourdois
2007-03-20 14:31 ` 2.6.21-rc4-mm1 Jiri Slaby
2007-03-20 16:09 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-20 18:38 ` 2.6.21-rc4-mm1 Pavel Machek
2007-03-20 19:40 ` 2.6.21-rc4-mm1 Jiri Slaby
2007-03-20 19:56 ` 2.6.21-rc4-mm1 Pavel Machek
2007-03-20 20:13 ` 2.6.21-rc4-mm1 Jiri Slaby
2007-03-20 20:21 ` [linux-pm] 2.6.21-rc4-mm1 Pavel Machek
2007-03-20 20:58 ` Rafael J. Wysocki
2007-03-20 20:58 ` Jiri Slaby
2007-03-20 21:06 ` Rafael J. Wysocki
[not found] ` <200703210149.33240.rjw@sisk.pl>
2007-03-21 1:23 ` [linux-pm] 2.6.21-rc4-mm1: freezing of processes broken Eric W. Biederman
2007-03-21 2:47 ` sukadev
2007-03-21 3:13 ` Nigel Cunningham
2007-03-21 14:23 ` Oleg Nesterov
2007-03-21 14:45 ` Rafael J. Wysocki
2007-03-21 16:20 ` Andrew Morton
2007-03-21 16:55 ` Oleg Nesterov
2007-03-21 17:08 ` Andrew Morton
2007-03-21 18:07 ` sukadev
2007-03-21 18:16 ` Eric W. Biederman
2007-03-21 18:23 ` sukadev
2007-03-21 17:15 ` Oleg Nesterov
2007-03-21 12:08 ` Rafael J. Wysocki
2007-03-20 20:12 ` 2.6.21-rc4-mm1 Rafael J. Wysocki
2007-03-20 16:36 ` 2.6.21-rc4-mm1 J.A. Magallón
2007-03-21 0:14 ` 2.6.21-rc4-mm1 J.A. Magallón
2007-03-20 17:31 ` 2.6.21-rc4-mm1 Randy Dunlap
2007-03-20 19:20 ` 2.6.21-rc4-mm1 Kees Cook
2007-03-20 20:42 ` 2.6.21-rc4-mm1 Stéphane Jourdois
2007-03-20 20:50 ` 2.6.21-rc4-mm1 Randy Dunlap
2007-03-21 5:47 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-21 11:25 ` 2.6.21-rc4-mm1 David Woodhouse
2007-03-21 11:59 ` 2.6.21-rc4-mm1 Sam Ravnborg
2007-03-22 9:17 ` 2.6.21-rc4-mm1 David Woodhouse
2007-03-22 11:41 ` 2.6.21-rc4-mm1 Sam Ravnborg
2007-03-22 16:25 ` 2.6.21-rc4-mm1 David Woodhouse
2007-03-22 16:28 ` 2.6.21-rc4-mm1 Sam Ravnborg
2007-03-21 22:19 ` 2.6.21-rc4-mm1 Sam Ravnborg
2007-03-21 22:22 ` [PATCH 1/3] kbuild: complain about missing system calls Sam Ravnborg
2007-05-07 22:29 ` Tony Luck
2007-05-07 22:39 ` David Woodhouse
2007-05-07 22:51 ` Luck, Tony
2007-05-08 18:24 ` Sam Ravnborg
2007-05-08 18:35 ` Luck, Tony
2007-05-08 18:49 ` Sam Ravnborg
2007-03-21 22:23 ` [PATCH 2/3] kbuild: ignore more i386 legacy syscalls Sam Ravnborg
2007-03-21 22:24 ` [PATCH 3/3] kbuild: exempt more syscalls from warnings, for x86_64 and ARM Sam Ravnborg
2007-03-21 23:01 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-22 8:54 ` 2.6.21-rc4-mm1 Sam Ravnborg
2007-03-20 18:09 ` [PATCH] utrace: make an inline void Randy Dunlap
2007-03-21 1:48 ` Roland McGrath
2007-03-20 20:49 ` 2.6.21-rc4-mm1: multiple definition of `queue_pushbutton_work' Adrian Bunk
2007-03-21 18:45 ` Kristen Carlson Accardi [this message]
2007-03-20 21:04 ` 2.6.21-rc4-mm1 J.A. Magallón
2007-03-20 23:10 ` FireWire update in -mm (was 2.6.21-rc4-mm1) Stefan Richter
2007-03-20 23:49 ` 2.6.21-rc4-mm1 Randy Dunlap
2007-03-21 1:47 ` 2.6.21-rc4-mm1 Randy Dunlap
2007-03-21 18:36 ` 2.6.21-rc4-mm1 Greg KH
[not found] ` <1174433034.62033.16.camel@localhost>
2007-03-21 6:36 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-21 9:52 ` 2.6.21-rc4-mm1 Edward Shishkin
2007-03-21 14:12 ` [Bluez-devel] 2.6.21-rc4-mm1 Marcel Holtmann
2007-03-23 19:45 ` Zan Lynx
2007-03-21 16:13 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-23 19:40 ` 2.6.21-rc4-mm1 Zan Lynx
2007-03-24 1:49 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-21 18:14 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-21 18:34 ` 2.6.21-rc4-mm1 Michael Buesch
2007-03-21 19:00 ` 2.6.21-rc4-mm1 John W. Linville
2007-03-21 18:59 ` 2.6.21-rc4-mm1 John W. Linville
2007-03-21 20:22 ` 2.6.21-rc4-mm1 Matt Mackall
2007-03-21 20:48 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-21 21:03 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-21 21:39 ` 2.6.21-rc4-mm1 Randy Dunlap
2007-03-21 21:45 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-22 7:39 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-22 11:35 ` 2.6.21-rc4-mm1 Cornelia Huck
[not found] ` <4602752A.5050109@lwfinger.net>
2007-03-22 17:10 ` 2.6.21-rc4-mm1 Cornelia Huck
2007-03-22 18:55 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-23 10:10 ` 2.6.21-rc4-mm1 Cornelia Huck
2007-03-23 15:00 ` 2.6.21-rc4-mm1 Larry Finger
2007-03-24 5:06 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-26 9:09 ` 2.6.21-rc4-mm1 Cornelia Huck
2007-03-26 9:22 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-26 10:34 ` 2.6.21-rc4-mm1 Eric Rannaud
2007-03-26 10:44 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-27 9:25 ` 2.6.21-rc4-mm1 Kay Sievers
2007-03-27 17:17 ` 2.6.21-rc4-mm1 Cornelia Huck
2007-03-28 1:26 ` 2.6.21-rc4-mm1 Eric Rannaud
2007-03-28 8:25 ` 2.6.21-rc4-mm1 Cornelia Huck
2007-03-24 22:32 ` 2.6.21-rc4-mm1 Matt Mackall
2007-03-21 18:49 ` 2.6.21-rc4-mm1 - problem with cpuidle routine Larry Finger
2007-03-21 20:38 ` Andrew Morton
2007-03-22 0:33 ` Venkatesh Pallipadi
2007-03-30 1:25 ` 2.6.21-rc4-mm1 and rc5-mm2 " Ed Sweetman
2007-03-30 2:17 ` Lee Revell
2007-03-21 20:39 ` 2.6.21-rc4-mm1 " Venki Pallipadi
2007-03-21 10:14 ` 2.6.21-rc4-mm1 Reuben Farrelly
2007-03-22 23:27 ` 2.6.21-rc4-mm1 J.A. Magallón
2007-03-23 1:41 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-26 20:31 ` 2.6.21-rc4-mm1 J.A. Magallón
2007-03-24 13:06 ` [-mm patch] lguest: #if 0 check_bug_kill() Adrian Bunk
2007-03-25 7:33 ` Rusty Russell
2007-03-25 14:57 ` [-mm patch] lguest: remove check_bug_kill() Adrian Bunk
2007-03-24 13:06 ` [-mm patch] drivers/scsi/constants.c: make 2 functions static Adrian Bunk
2007-03-24 16:11 ` Douglas Gilbert
2007-03-24 17:02 ` Adrian Bunk
2007-03-24 13:07 ` [-mm patch] fs/revoke.c: cleanups (and bugfix for 64bit systems) Adrian Bunk
2007-03-24 13:15 ` Pekka Enberg
2007-03-24 13:07 ` [-mm patch] unexport bio_{,un}map_user Adrian Bunk
2007-03-25 14:58 ` [-mm patch] drivers/eisa/pci_eisa.c:pci_eisa_init() should be init Adrian Bunk
2007-03-26 0:24 ` Wrong IDE cable detection in libata [Re: 2.6.21-rc4-mm1] J.A. Magallón
2007-03-26 11:01 ` Tejun Heo
2007-03-26 20:18 ` J.A. Magallón
2007-03-26 19:47 ` 2.6.21-rc4-mm1 Badari Pulavarty
2007-03-26 23:29 ` 2.6.21-rc4-mm1 Paul Mackerras
2007-03-26 20:05 ` 2.6.21-rc4-mm1 Badari Pulavarty
2007-03-26 19:35 ` 2.6.21-rc4-mm1 Jean Delvare
2007-03-26 23:26 ` 2.6.21-rc4-mm1 Greg KH
2007-03-26 21:57 ` 2.6.21-rc4-mm1 Badari Pulavarty
2007-03-26 22:22 ` 2.6.21-rc4-mm1 Andrew Morton
2007-03-26 23:43 ` 2.6.21-rc4-mm1 Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321114531.feffad51.kristen.c.accardi@intel.com \
--to=kristen.c.accardi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®