From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: venkatesh.pallipadi@intel.com, akpm <akpm@linux-foundation.org>
Subject: [PATCH -mm] cpuidle: unsigned bitfield
Date: Wed, 21 Mar 2007 19:23:00 -0700 [thread overview]
Message-ID: <20070321192300.6efd67fe.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
A 1-bit bitfield has no room for a sign bit.
drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without explicit `signed' or `unsigned'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/cpuidle/governors/ladder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.21-rc4-mm1.orig/drivers/cpuidle/governors/ladder.c
+++ linux-2.6.21-rc4-mm1/drivers/cpuidle/governors/ladder.c
@@ -51,7 +51,7 @@ struct ladder_device_state {
struct ladder_device {
struct ladder_device_state states[CPUIDLE_STATE_MAX];
- int bm_check:1;
+ unsigned int bm_check:1;
unsigned long bm_check_timestamp;
unsigned long bm_activity; /* FIXME: bm activity should be global */
int last_state_idx;
reply other threads:[~2007-03-22 2:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321192300.6efd67fe.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®