From: Al Viro <viro@ftp.linux.org.uk>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Alexey Dobriyan <adobriyan@sw.ru>,
Andrew Morton <akpm@linux-foundation.org>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1
Date: Thu, 22 Mar 2007 08:28:15 +0000 [thread overview]
Message-ID: <20070322082815.GV4095@ftp.linux.org.uk> (raw)
In-Reply-To: <20070322091445.0eecd44f.dada1@cosmosbay.com>
On Thu, Mar 22, 2007 at 09:14:45AM +0100, Eric Dumazet wrote:
> Also, do we really need to proxy via proc_reg_file_ops files that are not provided by a module ?
>
> I think not.
>
> Could you please add in proc_get_inode() a check against de->proc_fops->owner ?
Let's _not_. Bugs that depend on whether driver is built modular are
hell to deal with.
prev parent reply other threads:[~2007-03-22 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 8:14 Eric Dumazet
2007-03-22 8:28 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322082815.GV4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®