mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: michal.k.k.piotrowski@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded
Date: Sat, 24 Mar 2007 12:36:13 -0700 (PDT)	[thread overview]
Message-ID: <20070324.123613.130229822.davem@davemloft.net> (raw)
In-Reply-To: <20070324101653.602d9a79.akpm@linux-foundation.org>

From: Andrew Morton <akpm@linux-foundation.org>
Date: Sat, 24 Mar 2007 10:16:53 -0800

> On Sat, 24 Mar 2007 18:18:42 +0100 "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com> wrote:
> 
> > On 24/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> > > The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
> > >
> > >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
> > >
> > 
> > My network doesn't work
> > "RTNETLINK answers: Invalid argument"
> > 
> > git-net* patches?
> > 
> 
> There's a huge collision between git-net and git-wireless which I haven't
> started to look at yet.  I suggest you forget about that particular
> snapshot.

We fixed that bug about a day after you likely took a snapshot
of the net-2.6.22 tree.

Here is the fix:

commit 65f96c1f4b549a3c3c19cebf9f0795c0d8fb35f0
Author: Thomas Graf <tgraf@suug.ch>
Date:   Thu Mar 22 21:41:06 2007 -0700

    [RTNL]: Properly return rntl message handler
    
    Signed-off-by: Thomas Graf <tgraf@suug.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 35ce9f7..3a295e3 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -122,10 +122,10 @@ static rtnl_doit_func rtnl_get_doit(int protocol, int msgindex)
 	struct rtnl_link *tab;
 
 	tab = rtnl_msg_handlers[protocol];
-	if (tab == NULL || tab->doit == NULL)
+	if (tab == NULL || tab[msgindex].doit == NULL)
 		tab = rtnl_msg_handlers[PF_UNSPEC];
 
-	return tab ? tab->doit : NULL;
+	return tab ? tab[msgindex].doit : NULL;
 }
 
 static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
@@ -133,10 +133,10 @@ static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
 	struct rtnl_link *tab;
 
 	tab = rtnl_msg_handlers[protocol];
-	if (tab == NULL || tab->dumpit == NULL)
+	if (tab == NULL || tab[msgindex].dumpit == NULL)
 		tab = rtnl_msg_handlers[PF_UNSPEC];
 
-	return tab ? tab->dumpit : NULL;
+	return tab ? tab[msgindex].dumpit : NULL;
 }
 
 /**

  reply	other threads:[~2007-03-24 21:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200703240816.l2O8GLLS001929@shell0.pdx.osdl.net>
2007-03-24 11:35 ` Michal Piotrowski
2007-03-24 15:38   ` Andrew Morton
2007-03-24 11:54 ` Michal Piotrowski
2007-03-24 17:18 ` Michal Piotrowski
2007-03-24 18:16   ` Andrew Morton
2007-03-24 19:36     ` David Miller [this message]
2007-03-25 11:52       ` Michal Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070324.123613.130229822.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®