From: Adrian Bunk <bunk@stusta.de>
To: Parag Warudkar <parag.warudkar@gmail.com>
Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
John Stultz <johnstul@us.ibm.com>
Subject: Re: apm.c: get rid of unused variables
Date: Sun, 25 Mar 2007 18:25:05 +0200 [thread overview]
Message-ID: <20070325162505.GN16477@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0703251158400.17623@paragw-desktop>
On Sun, Mar 25, 2007 at 12:06:19PM -0400, Parag Warudkar wrote:
>
> The patch below (against latest git) gets rid of following unused
> variables - clock_cmos_diff and got_clock_diff.
>
> 2 less compiler warnings.
>
> Compile tested on i386.
>
> Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
>
> --- linux-2.6/arch/i386/kernel/apm.c 2007-03-24 21:43:35.000000000 -0400
> +++ linux-2.6-wk/arch/i386/kernel/apm.c 2007-03-25
> 11:50:16.000000000 -0400
> @@ -384,13 +384,6 @@
> static int ignore_normal_resume;
> static int bounce_interval __read_mostly =
> DEFAULT_BOUNCE_INTERVAL;
>
> -#ifdef CONFIG_APM_RTC_IS_GMT
> -# define clock_cmos_diff 0
> -# define got_clock_diff 1
> -#else
> -static long clock_cmos_diff;
> -static int got_clock_diff;
> -#endif
> static int debug __read_mostly;
> static int smp __read_mostly;
> static int apm_disabled = -1;
You could also remove the APM_RTC_IS_GMT config option.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-03-25 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-25 16:06 Parag Warudkar
2007-03-25 16:25 ` Adrian Bunk [this message]
2007-03-25 17:07 ` Parag Warudkar
2007-03-25 21:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070325162505.GN16477@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=parag.warudkar@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome