From: Pete Zaitcev <zaitcev@redhat.com>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz, zaitcev@redhat.com
Subject: Re: Fix sudden warps in mousedev
Date: Mon, 26 Mar 2007 12:17:18 -0700 [thread overview]
Message-ID: <20070326121718.3940a579.zaitcev@redhat.com> (raw)
In-Reply-To: <200703252319.39676.dtor@insightbb.com>
On Sun, 25 Mar 2007 23:19:38 -0400, Dmitry Torokhov <dtor@insightbb.com> wrote:
> I tried to reproduce warping on console but could not for some reason. Could you
> please try the patch below and tell me if it fixes the problem for you?
> +++ work/drivers/input/mousedev.c
> @@ -124,32 +124,33 @@ static void mousedev_touchpad_event(stru
> - if (mousedev->pkt_count >= 2) {
> + if (mousedev->touch && mousedev->pkt_count >= 2) {
This works, thanks a lot.
The double-indented switch() is annoying, but since the whole driver
is written to the same style, I can live with it, for the uniformity
purposes :-)
You can't imagine the relief of using a reliable pointer again, after
months of touching the pad with a certain trepidation.
-- Pete
next prev parent reply other threads:[~2007-03-26 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 7:16 Pete Zaitcev
[not found] ` <200703250134.03416.dtor@insightbb.com>
2007-03-25 18:19 ` Pete Zaitcev
2007-03-26 3:19 ` Dmitry Torokhov
2007-03-26 19:17 ` Pete Zaitcev [this message]
2007-03-26 19:30 ` Dmitry Torokhov
2007-03-26 21:42 ` Pete Zaitcev
2007-03-27 1:14 ` Dmitry Torokhov
2007-03-27 15:14 ` Chuck Ebbert
2007-03-27 15:46 ` Dmitry Torokhov
2007-03-27 16:04 ` Chuck Ebbert
2007-03-27 16:19 ` Dmitry Torokhov
2007-03-28 20:51 ` Matt Keenan
2007-04-11 21:51 ` Peter Osterlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070326121718.3940a579.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=dtor@insightbb.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome