From: David Brownell <david-b@pacbell.net>
To: bryan.wu@analog.com
Cc: dbrownell@users.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] Blackfin: spi driver cleanup and coding style fixing
Date: Mon, 26 Mar 2007 15:36:56 -0700 [thread overview]
Message-ID: <200703261536.56689.david-b@pacbell.net> (raw)
In-Reply-To: <1174904080.32691.77.camel@roc-desktop>
On Monday 26 March 2007 3:14 am, Wu, Bryan wrote:
> Hi folks,
>
> This patch cleanup blackfin SPI driver code and fix some coding style
> problems.
Good, thanks. I'll forward the current state of my review, after
I cross-check it against these two patches.
That'll mean I need to re-start that review ... at that point it'd
be better to start with a single clean patch.
> -#ifdef DEBUG
> -#define ASSERT(expr) \
> - if (!(expr)) { \
> - printk(KERN_DEBUG "assertion failed! %s[%d]: %s\n", \
> - __FUNCTION__, __LINE__, #expr); \
> - panic(KERN_DEBUG "%s", __FUNCTION__); \
> - }
> -#else
> -#define ASSERT(expr)
> -#endif
Yes, that was certainly in the "remove that" category.
- Dave
prev parent reply other threads:[~2007-03-26 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 10:14 Wu, Bryan
2007-03-26 22:36 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703261536.56689.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome